Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Endpoint] Logic to check and complete pending get-file response actions for SentinelOne #181766

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

paul-tavares
Copy link
Contributor

Summary

WIP 🚧

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@paul-tavares paul-tavares added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.15.0 labels Apr 25, 2024
@paul-tavares paul-tavares self-assigned this Apr 25, 2024
@paul-tavares paul-tavares changed the title [Security Solution][Endpoint] Adds logic to check and complete pending get-file response actions for SentinelOne [Security Solution][Endpoint] Logic to check and complete pending get-file response actions for SentinelOne May 6, 2024
@paul-tavares
Copy link
Contributor Author

/ci

@paul-tavares
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented May 7, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #13 / fetchActionResponses() should query both fleet and endpoint indexes
  • [job] [logs] Jest Tests #13 / fetchActionResponses() should query both fleet and endpoint indexes
  • [job] [logs] Jest Tests #13 / fetchActionResponses() should return empty array with no responses exist
  • [job] [logs] Jest Tests #13 / fetchActionResponses() should return empty array with no responses exist
  • [job] [logs] Jest Tests #13 / fetchActionResponses() should return results
  • [job] [logs] Jest Tests #13 / fetchActionResponses() should return results
  • [job] [logs] Jest Tests #13 / Response Action file info API Route handler should error if action ID is invalid
  • [job] [logs] Jest Tests #13 / Response Action file info API Route handler should error if action ID is invalid
  • [job] [logs] Jest Tests #13 / Response Action file info API Route handler should error if file ID is invalid
  • [job] [logs] Jest Tests #13 / Response Action file info API Route handler should error if file ID is invalid
  • [job] [logs] Jest Tests #13 / Response Action file info API Route handler should respond with expected output
  • [job] [logs] Jest Tests #13 / Response Action file info API Route handler should respond with expected output
  • [job] [logs] Jest Tests #13 / Response Action file info API Route handler should retrieve the file info with correct file id
  • [job] [logs] Jest Tests #13 / Response Action file info API Route handler should retrieve the file info with correct file id
  • [job] [logs] Jest Tests #13 / Response Actions file download API Route handler should error if action ID is invalid
  • [job] [logs] Jest Tests #13 / Response Actions file download API Route handler should error if action ID is invalid
  • [job] [logs] Jest Tests #13 / Response Actions file download API Route handler should error if file ID is invalid
  • [job] [logs] Jest Tests #13 / Response Actions file download API Route handler should error if file ID is invalid
  • [job] [logs] Jest Tests #13 / Response Actions file download API Route handler should respond with expected HTTP headers
  • [job] [logs] Jest Tests #13 / Response Actions file download API Route handler should respond with expected HTTP headers
  • [job] [logs] Jest Tests #13 / Response Actions file download API Route handler should retrieve the download Stream using correct file ID
  • [job] [logs] Jest Tests #13 / Response Actions file download API Route handler should retrieve the download Stream using correct file ID
  • [job] [logs] Jest Tests #13 / SentinelOneActionsClient class #processPendingActions() for Get File should generate an action success response doc
  • [job] [logs] Jest Tests #13 / SentinelOneActionsClient class #processPendingActions() for Get File should generate an action success response doc
  • [job] [logs] Jest Tests #13 / When using `getActionList() should return an empty array if no actions are found
  • [job] [logs] Jest Tests #13 / When using `getActionList() should return an empty array if no actions are found

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.3MB 15.3MB +42.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 519 521 +2

Total ESLint disabled count

id before after diff
securitySolution 597 599 +2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @paul-tavares

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants