[ML] Transforms: Improve data view checks. #181892
Conversation
walterra
force-pushed
the
ml-transform-fix-data-view-checks
branch
from
77b0150
to
2e6abe5
Compare
|
Pinging @elastic/ml-ui (:ml) |
walterra
changed the title
| const dataViewTitle = Array.isArray(item.config.source.index) | ||
| ? item.config.source.index.join(',') | ||
| : item.config.source.index; | ||
| const dataViewId = getDataViewIdByTitle(dataViewTitle); | ||
| const dataViewListItem = dataViewListItems.find((d) => d.title === dataViewTitle); |
There was a problem hiding this comment.
Each of the uses of dataViewListItems runs a find, these won't be too expensive, but it might be slightly more efficient if useGetDataViewIdsWithTitle returned a map of data views, keyed on title
There was a problem hiding this comment.
👍 Updated the hook to return a map, also renamed everything to be in line with the new returned structure in 9f23cb8.
x-pack/plugins/transform/public/app/hooks/use_get_data_views_title_id_map.ts
Outdated
Show resolved
Hide resolved
| const toastNotifications = useToastNotifications(); | ||
|
|
||
| const { getDataViewIdByTitle, loadDataViews } = useSearchItems(undefined); | ||
|
|
||
| const { data: dataViewsTitleIdMap } = useGetDataViewsTitleIdMap(); |
There was a problem hiding this comment.
Total nit pick. but rather than having to rename data -> dataViewsTitleIdMap on every use, could it be renamed when being returned from useGetDataViewsTitleIdMap ?
There was a problem hiding this comment.
This hook wraps useQuery so that whole returned object comes from it and data is part of its standard API (like isLoading, error etc.).
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @walterra |
Summary
Part of #181603.
For some of the actions in the transform list we need to identify if there's a data view for the target index. The way we identified this was quite inefficient. We had poor caching in place and fetched info for all data views including fields — this can be quite expensive queries!
This update fixes the approach and switches to using
dataViews.getIdsWithTitle()in combination withuseQuery()to bring the caching in line with how we load and refresh the rest of the transform list.Before: Lots of field caps requests!
After: We do just 1
_searchrequest that gets the data view ids/titles:Checklist