Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] add azure-storage-account for csp billing #181971

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Cloud Security] add azure-storage-account for csp billing #181971

wants to merge 2 commits into from
+2 −2

Conversation

maxcold
Copy link
Contributor

@maxcold maxcold commented Apr 29, 2024 •
edited

Summary

Initially azure-storage-account wasn't included in the billing due to unclear relationship with the actual number of Azure blob storage assets. But as we don't have a better way to count storage assets in Azure we should include it.

Also removing gcp-bigquery-table from assets as per discussion with @smriti0321

Part of:

@maxcold maxcold added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Cloud Security Cloud Security team related labels Apr 29, 2024
@maxcold maxcold requested review from joeypoon and a team April 29, 2024 11:57
@maxcold
Copy link
Contributor Author

maxcold commented Apr 29, 2024

/ci

@maxcold maxcold marked this pull request as ready for review April 30, 2024 07:07
@maxcold maxcold requested a review from a team as a code owner April 30, 2024 07:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@maxcold maxcold requested a review from JordanSh April 30, 2024 11:58
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #10 / dashboard app - group 1 dashboard embeddable data grid are added when a cell filter is clicked
  • [job] [logs] FTR Configs #16 / maps app documents source docvalue_fields should only fetch geo_point field and data driven styling fields

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeypoon joeypoon joeypoon approved these changes

@JordanSh JordanSh JordanSh approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@maxcold @elasticmachine @kibana-ci @joeypoon @JordanSh