Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution ] Skip Detection Engine Filters flaky test #181985

Merged
merged 3 commits into from
Apr 29, 2024
Merged

[Security Solution ] Skip Detection Engine Filters flaky test #181985

merged 3 commits into from
Apr 29, 2024

Conversation

logeekal
Copy link
Contributor

Summary

Skips flaky test as per : #181977

@logeekal logeekal requested a review from a team as a code owner April 29, 2024 13:33
@logeekal logeekal enabled auto-merge (squash) April 29, 2024 13:34
@logeekal logeekal added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team labels Apr 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@PhilippeOberti
Copy link
Contributor

seems that it's been skipped already #181977 (comment)

@logeekal
Copy link
Contributor Author

logeekal commented Apr 29, 2024 •
edited

@PhilippeOberti , they skipped the complete suite .. I will modify this PR to only skip that particular test.

@logeekal logeekal disabled auto-merge April 29, 2024 13:48
@PhilippeOberti
Copy link
Contributor

@PhilippeOberti , they skipped the complete suit .. I will modify this PR to only skip that particular test.

yup that's a good idea. It's a bit annoying that they skip the entire suite honestly...

@logeekal
Copy link
Contributor Author

yup that's a good idea. It's a bit annoying that they skip the entire suite honestly...

No doubt.. The speed at which they merge this change.. feels like somehow this is automated or they force-merge the PR. Do you know what is it?

@PhilippeOberti
Copy link
Contributor

No doubt.. The speed at which they merge this change.. feels like somehow this is automated or they force-merge the PR. Do you know what is it?

I do not but I've been wondering the same thing for a while!

@logeekal logeekal enabled auto-merge (squash) April 29, 2024 14:06
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@logeekal logeekal merged commit a452d36 into elastic:main Apr 29, 2024
34 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Apr 29, 2024
yuliacech pushed a commit to yuliacech/kibana that referenced this pull request May 3, 2024
@logeekal @yuliacech
[Security Solution ] Skip Detection Engine Filters flaky test (elasti…
91b884a 
…c#181985)

## Summary

Skips flaky test as per :
elastic#181977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelolo24 michaelolo24 michaelolo24 approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@logeekal @elasticmachine @PhilippeOberti @kibana-ci @michaelolo24 @kibanamachine