[Dataset quality] Fix flyout error when closed after navigation #182026
Conversation
…r precedence issues.
awahab07
added
bug
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/ci |
|
Works great, thank you |
| setFlyoutState, | ||
| ] = useState(flyoutState); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
I am not getting why do we need this useEffect, I have a feeling that its not needed
There was a problem hiding this comment.
Yes, I've simplified the code and removed useEffect.
| datasetIntegrationsLoading, | ||
| }; | ||
| }, [dataStreamDetailsLoading, dataStreamSettingsLoading, datasetIntegrationsLoading]); | ||
| const loadingState = useSelector(service, (state) => ({ |
There was a problem hiding this comment.
Why do we need to keep all these ones together?
I think it's better if they are separate because they are different requests, so we can show information as soon as it arrives instead of waiting for all of them to return data
There was a problem hiding this comment.
They are still separate, just the code is simplified.
💚 Build Succeeded
Metrics [docs]Async chunks
Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: |
…tic#182026) Fixes elastic#179880 ## Summary The PR fixes the error reported in the parent issue by making sure Dataset Quality flyout more receptive to `undefined` flyout state.
Fixes #179880
Summary
The PR fixes the error reported in the parent issue by making sure Dataset Quality flyout more receptive to
undefinedflyout state.