Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add missing totalSeconds field #182093

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented Apr 30, 2024

Summary

The PR #182001 was verified at a point where typechecking was missing for a bit, this allowed a missing field to slip in. This PR tries to fix it.

@delanni
Copy link
Contributor Author

delanni commented Apr 30, 2024

/ci

@delanni delanni added release_note:skip Skip the PR/issue when compiling release notes v8.14.0 v8.15.0 labels Apr 30, 2024
@delanni delanni marked this pull request as ready for review April 30, 2024 10:05
@delanni delanni requested a review from a team as a code owner April 30, 2024 10:05
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing it @delanni

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Apr 30, 2024
@delanni delanni merged commit 370a7f5 into elastic:main Apr 30, 2024
12 of 16 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 30, 2024
## Summary
The PR elastic#182001 was verified at a
point where typechecking was missing for a bit, this allowed a missing
field to slip in. This PR tries to fix it.

(cherry picked from commit 370a7f5)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine added a commit that referenced this pull request Apr 30, 2024
# Backport

This will backport the following commits from `main` to `8.14`:
- [[Fix] Add missing totalSeconds field
(#182093)](#182093)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alex
Szabo","email":"alex.szabo@elastic.co"},"sourceCommit":{"committedDate":"2024-04-30T10:09:02Z","message":"[Fix]
Add missing totalSeconds field (#182093)\n\n## Summary\r\nThe PR
#182001 was verified at a\r\npoint
where typechecking was missing for a bit, this allowed a
missing\r\nfield to slip in. This PR tries to fix
it.","sha":"370a7f5ec625fec1d082b331bfe431b68ed63688","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","v8.14.0","v8.15.0"],"title":"[Fix]
Add missing totalSeconds
field","number":182093,"url":"#182093
Add missing totalSeconds field (#182093)\n\n## Summary\r\nThe PR
#182001 was verified at a\r\npoint
where typechecking was missing for a bit, this allowed a
missing\r\nfield to slip in. This PR tries to fix
it.","sha":"370a7f5ec625fec1d082b331bfe431b68ed63688"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182093
Add missing totalSeconds field (#182093)\n\n## Summary\r\nThe PR
#182001 was verified at a\r\npoint
where typechecking was missing for a bit, this allowed a
missing\r\nfield to slip in. This PR tries to fix
it.","sha":"370a7f5ec625fec1d082b331bfe431b68ed63688"}}]}] BACKPORT-->

Co-authored-by: Alex Szabo <alex.szabo@elastic.co>
mbondyra pushed a commit to mbondyra/kibana that referenced this pull request May 2, 2024
## Summary
The PR elastic#182001 was verified at a
point where typechecking was missing for a bit, this allowed a missing
field to slip in. This PR tries to fix it.
@delanni delanni deleted the fix-missing-total-seconds branch May 2, 2024 11:26
yuliacech pushed a commit to yuliacech/kibana that referenced this pull request May 3, 2024
## Summary
The PR elastic#182001 was verified at a
point where typechecking was missing for a bit, this allowed a missing
field to slip in. This PR tries to fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:review ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants