[Lens] Fix table sorting on time picker interval change #182173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dej611
added
release_note:fix
Team:Visualizations
|
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
nickofthyme
approved these changes
May 1, 2024
| @@ -218,15 +226,19 @@ function getUndefinedHandler( | |||
| if (valueB == null || Number.isNaN(valueB)) { | |||
| return -1; | |||
| } | |||
| return sortingCriteria(rowA, rowB, direction); | |||
| return sortingCriteria(rowA!, rowB!, direction); | |||
There was a problem hiding this comment.
Type guards are always preferable to ! 💥
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 1, 2024
## Summary Fixes elastic#182153 Due to some specific implementation of the schema sorting in the EUI datagrid, sometimes the table row can be `null/undefined` and the comparison function utility wasn't prepared for that. Now the utility is resilient to `null` rows. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 085d236)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 1, 2024
## Summary Fixes elastic#182153 Due to some specific implementation of the schema sorting in the EUI datagrid, sometimes the table row can be `null/undefined` and the comparison function utility wasn't prepared for that. Now the utility is resilient to `null` rows. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 085d236)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 1, 2024
…) (#182215) # Backport This will backport the following commits from `main` to `8.13`: - [[Lens] Fix table sorting on time picker interval change (#182173)](#182173) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-01T05:04:29Z","message":"[Lens] Fix table sorting on time picker interval change (#182173)\n\n## Summary\r\n\r\nFixes #182153 \r\n\r\nDue to some specific implementation of the schema sorting in the EUI\r\ndatagrid, sometimes the table row can be `null/undefined` and the\r\ncomparison function utility wasn't prepared for that.\r\nNow the utility is resilient to `null` rows.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"085d2368b08df645966a450025e297524682da4a","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","v8.14.0","v8.13.3","v8.15.0"],"title":"[Lens] Fix table sorting on time picker interval change","number":182173,"url":"#182173 Fix table sorting on time picker interval change (#182173)\n\n## Summary\r\n\r\nFixes #182153 \r\n\r\nDue to some specific implementation of the schema sorting in the EUI\r\ndatagrid, sometimes the table row can be `null/undefined` and the\r\ncomparison function utility wasn't prepared for that.\r\nNow the utility is resilient to `null` rows.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"085d2368b08df645966a450025e297524682da4a"}},"sourceBranch":"main","suggestedTargetBranches":["8.14","8.13"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.13","label":"v8.13.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182173 Fix table sorting on time picker interval change (#182173)\n\n## Summary\r\n\r\nFixes #182153 \r\n\r\nDue to some specific implementation of the schema sorting in the EUI\r\ndatagrid, sometimes the table row can be `null/undefined` and the\r\ncomparison function utility wasn't prepared for that.\r\nNow the utility is resilient to `null` rows.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"085d2368b08df645966a450025e297524682da4a"}}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
May 1, 2024
…) (#182216) # Backport This will backport the following commits from `main` to `8.14`: - [[Lens] Fix table sorting on time picker interval change (#182173)](#182173) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Marco Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-01T05:04:29Z","message":"[Lens] Fix table sorting on time picker interval change (#182173)\n\n## Summary\r\n\r\nFixes #182153 \r\n\r\nDue to some specific implementation of the schema sorting in the EUI\r\ndatagrid, sometimes the table row can be `null/undefined` and the\r\ncomparison function utility wasn't prepared for that.\r\nNow the utility is resilient to `null` rows.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"085d2368b08df645966a450025e297524682da4a","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","v8.14.0","v8.13.3","v8.15.0"],"title":"[Lens] Fix table sorting on time picker interval change","number":182173,"url":"#182173 Fix table sorting on time picker interval change (#182173)\n\n## Summary\r\n\r\nFixes #182153 \r\n\r\nDue to some specific implementation of the schema sorting in the EUI\r\ndatagrid, sometimes the table row can be `null/undefined` and the\r\ncomparison function utility wasn't prepared for that.\r\nNow the utility is resilient to `null` rows.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"085d2368b08df645966a450025e297524682da4a"}},"sourceBranch":"main","suggestedTargetBranches":["8.14","8.13"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.13","label":"v8.13.3","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182173 Fix table sorting on time picker interval change (#182173)\n\n## Summary\r\n\r\nFixes #182153 \r\n\r\nDue to some specific implementation of the schema sorting in the EUI\r\ndatagrid, sometimes the table row can be `null/undefined` and the\r\ncomparison function utility wasn't prepared for that.\r\nNow the utility is resilient to `null` rows.\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"085d2368b08df645966a450025e297524682da4a"}}]}] BACKPORT--> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
|
This didn't make it to BC2 of 8.13.3. Removing the label Thanks! |
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
## Summary Fixes elastic#182153 Due to some specific implementation of the schema sorting in the EUI datagrid, sometimes the table row can be `null/undefined` and the comparison function utility wasn't prepared for that. Now the utility is resilient to `null` rows. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #182153
Due to some specific implementation of the schema sorting in the EUI datagrid, sometimes the table row can be
null/undefinedand the comparison function utility wasn't prepared for that.Now the utility is resilient to
nullrows.Checklist