Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Roles] Support for remote_cluster field in ES role definition #182377

Merged
merged 23 commits into from
May 8, 2024

Conversation

elena-shostak
Copy link
Contributor

@elena-shostak elena-shostak commented May 2, 2024

Summary

Added support for remote_cluster field in ES role definition. The change is needed for running queries with ENRICH keyword that are sent over CCS.

  • Updated GET and PUT APIs, documentation and corresponding data models.
  • Added UI section to support the new API features.
  • Extracted remote clusters ComboBox to a separate component RemoteClusterComboBox to share it between the remote clusters and remote index privilege views.
Screen.Recording.2024-05-06.at.12.36.23.mov

Checklist

For maintainers

Fixes: #182035

Release note

Added support for remote_cluster field in ES role definition.

@elena-shostak
Copy link
Contributor Author

/ci

2 similar comments
@elena-shostak
Copy link
Contributor Author

/ci

@elena-shostak
Copy link
Contributor Author

/ci

@elastic elastic deleted a comment from kibana-ci May 2, 2024
@elena-shostak
Copy link
Contributor Author

/ci

2 similar comments
@elena-shostak
Copy link
Contributor Author

/ci

@elena-shostak
Copy link
Contributor Author

/ci

@elena-shostak
Copy link
Contributor Author

/ci

@elena-shostak elena-shostak added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! Feature:Users/Roles/API Keys release_note:enhancement 8.15 candidate labels May 6, 2024
@elena-shostak elena-shostak changed the title [Roles] Added support for remote_cluster field [Roles] Added support for remote_cluster field in ES role definition May 6, 2024
@elena-shostak elena-shostak changed the title [Roles] Added support for remote_cluster field in ES role definition [Roles] Added support for remote_cluster field in ES role definition May 6, 2024
@elena-shostak elena-shostak changed the title [Roles] Added support for remote_cluster field in ES role definition [Roles] Support for remote_cluster field in ES role definition May 6, 2024
@elena-shostak
Copy link
Contributor Author

/ci

1 similar comment
@elena-shostak
Copy link
Contributor Author

/ci

@elena-shostak elena-shostak marked this pull request as ready for review May 6, 2024 14:14
@elena-shostak elena-shostak requested a review from a team as a code owner May 6, 2024 14:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kc13greiner kc13greiner self-requested a review May 6, 2024 14:59
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just a few questions to help me complete my review!

Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for discussing 🚀

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
security 512 515 +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/security-plugin-types-common 37 40 +3
security 201 205 +4
total +7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
security 564.8KB 571.4KB +6.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
security 68.9KB 68.9KB +95.0B
Unknown metric groups

API count

id before after diff
@kbn/security-plugin-types-common 84 88 +4
security 407 413 +6
total +10

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elena-shostak elena-shostak merged commit 25098d9 into elastic:main May 8, 2024
18 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 8, 2024
elena-shostak added a commit to elena-shostak/kibana that referenced this pull request Jun 11, 2024
elena-shostak added a commit to elena-shostak/kibana that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.15 candidate backport:skip This commit does not require backporting Feature:Users/Roles/API Keys release_note:enhancement Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "remote_cluster" in ES role definition
6 participants