-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Roles] Support for remote_cluster field in ES role definition #182377
[Roles] Support for remote_cluster field in ES role definition #182377
Conversation
/ci |
2 similar comments
/ci |
/ci |
...lugins/security/public/management/roles/edit_role/privileges/es/elasticsearch_privileges.tsx
Outdated
Show resolved
Hide resolved
4d47b4b
to
f034f2e
Compare
/ci |
2 similar comments
/ci |
/ci |
d724c81
to
20510ee
Compare
/ci |
remote_cluster
field in ES role definition
remote_cluster
field in ES role definition
/ci |
1 similar comment
/ci |
Pinging @elastic/kibana-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just a few questions to help me complete my review!
.../security/public/management/roles/edit_role/privileges/es/remote_cluster_privileges.test.tsx
Outdated
Show resolved
Hide resolved
...s/security/public/management/roles/edit_role/privileges/es/elasticsearch_privileges.test.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for discussing 🚀
0f06546
to
5b7c3b5
Compare
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Summary
Added support for
remote_cluster
field in ES role definition. The change is needed for running queries withENRICH
keyword that are sent over CCS.Screen.Recording.2024-05-06.at.12.36.23.mov
Checklist
For maintainers
Fixes: #182035
Release note
Added support for
remote_cluster
field in ES role definition.