Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] decouple ML plugin from Map embeddable #182409

Merged
merged 7 commits into from
May 7, 2024
Merged

[ML] decouple ML plugin from Map embeddable #182409

merged 7 commits into from
May 7, 2024

Conversation

nreese
Copy link
Contributor

@nreese nreese commented May 2, 2024

Part of #182020

@nreese nreese mentioned this pull request May 2, 2024
Closed
5 tasks
@nreese
Copy link
Contributor Author

nreese commented May 2, 2024

/ci

@nreese
Copy link
Contributor Author

nreese commented May 2, 2024

/ci

@nreese nreese marked this pull request as ready for review May 2, 2024 20:30
@nreese nreese requested review from a team as code owners May 2, 2024 20:30
@nreese nreese added :ml Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas release_note:skip Skip the PR/issue when compiling release notes project:embeddableRebuild v8.15.0 labels May 2, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor Author

nreese commented May 3, 2024

@elasticmachine merge upstream

nickpeihl
nickpeihl approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review

x-pack/plugins/ml/public/application/jobs/new_job/common/map_loader/map_loader.ts
@@ -41,11 +40,10 @@ export class MapLoader extends ChartLoader {
? `${splitField.name}:${fieldValues[0]} ${query ? `and ${query}` : ''}`
: `${query ? query : ''}`;

const params: any = {
const params: CreateLayerDescriptorParams = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Nice to get rid of this any.

@nreese
Copy link
Contributor Author

nreese commented May 6, 2024

@elasticmachine merge upstream

@alvarezmelissa87
Copy link
Contributor

This looks like it's going to be a big improvement - thanks for your work here.
Just found an issue where the anomaly point isn't showing up in the map. In the anomaly explorer for a geo job, when you click on a swimlane cell that corresponds to an anomaly, the map should show up with the corresponding anomaly like so:

image

With this change I'm getting an empty map.

@alvarezmelissa87 alvarezmelissa87 self-requested a review May 7, 2024 15:48
alvarezmelissa87
alvarezmelissa87 requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anomaly explorer map should be showing the corresponding anomaly in the map.

@nreese
Copy link
Contributor Author

nreese commented May 7, 2024

@elasticmachine merge upstream

alvarezmelissa87
alvarezmelissa87 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM ⚡

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 2017 2015 -2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
maps 276 281 +5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.1MB 4.1MB -4.9KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
maps 32 31 -1
Unknown metric groups

API count

id before after diff
maps 281 286 +5

ESLint disabled line counts

id before after diff
ml 551 547 -4

Total ESLint disabled count

id before after diff
ml 554 550 -4

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nreese nreese merged commit 8c20433 into elastic:main May 7, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickpeihl nickpeihl nickpeihl approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting :ml project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nreese @elasticmachine @alvarezmelissa87 @kibana-ci @nickpeihl @kibanamachine