[Security Solution] - Rename esql setting #182432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelolo24
added
release_note:skip
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
vitaliidm
approved these changes
May 2, 2024
vitaliidm
reviewed
May 2, 2024
| export const useEsqlAvailability = () => { | ||
| const { uiSettings } = useKibana().services; | ||
| const isEsqlAdvancedSettingEnabled = uiSettings?.get('discover:enableESQL'); | ||
| const isEsqlAdvancedSettingEnabled = uiSettings?.get('enableESQL'); |
There was a problem hiding this comment.
maybe we can use const variable according to #181616 (comment)
There was a problem hiding this comment.
Yea, agreed. Done, just rushed a little to make BC3, but updated as I think we should be okay 😄
michaelolo24
force-pushed
the
rename-esql-setting
branch
from
3600d48
to
06db5f9
Compare
This was referenced May 2, 2024
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
yuliacech
pushed a commit
to yuliacech/kibana
that referenced
this pull request
May 3, 2024
## Summary Follow up to this PR: elastic#181616 Renaming `discover:enableEsql` to `enableESQL` according to this change: elastic#182074
This was referenced May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to this PR: #181616
Renaming
discover:enableEsqltoenableESQLaccording to this change: #182074