-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kbn-test] improve error handling for saml auth #182511
[kbn-test] improve error handling for saml auth #182511
Conversation
/ci |
value = value.slice(0, value.length - 1); | ||
} | ||
|
||
if (value.length > 253) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get the feeling there's a great reason for this, but why 253?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire hostname, including the delimiting dots, has a maximum of 253 ASCII characters
email: string, | ||
kbnHost: string, | ||
log: ToolingLog | ||
) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this function be typed? Just a tiny almost-a-nit lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
Summary
If cloud user has no access to the project, we get error message like
Error: Failed to parse SAML response value
. This error does not explain the issue and especially because request returns 200 OK (due to redirects)This PR disables redirects for API call that creates SAML response, so if user has no access to the project response code is 303. To better explain the issue extended message is logged:
The PR also adds test coverage for the SAML auth in Cloud, to make sure we don't break stuff with new changes