Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add synthetic serverless doc links #182740

Merged
merged 11 commits into from
May 8, 2024

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented May 6, 2024

Summary

Adds Synthetic Serverless doc links (and one missing logs link).

Closes https://github.com/elastic/obs-docs-team/issues/219.

@bmorelli25 bmorelli25 requested a review from dedemorton May 6, 2024 18:21
@bmorelli25 bmorelli25 requested a review from a team as a code owner May 6, 2024 18:21
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@bmorelli25 bmorelli25 added release_note:skip Skip the PR/issue when compiling release notes v8.13.0 v8.14.0 labels May 6, 2024
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor issues.

packages/kbn-doc-links/src/get_doc_links.ts Outdated Show resolved Hide resolved
packages/kbn-doc-links/src/get_doc_links.ts Outdated Show resolved Hide resolved
tlsCertificate: `${OBSERVABILITY_DOCS}tls-certificate-alert.html`,
uptimeDurationAnomaly: `${OBSERVABILITY_DOCS}duration-anomaly-alert.html`,
monitorLogs: `${OBSERVABILITY_DOCS}monitor-logs.html`,
monitorLogs: isServerless
? `${SERVERLESS_OBSERVABILITY_DOCS}discover-and-explore-logs`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdbirnstiehl should confirm that this is the correct link (I'm not sure where the link appears in the UI).

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
@bmorelli25 bmorelli25 enabled auto-merge (squash) May 7, 2024 22:26
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 141.6KB 141.8KB +248.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 408.0KB 408.2KB +248.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming Mike likes the logging link.

@bmorelli25 bmorelli25 merged commit e7a9291 into elastic:main May 8, 2024
19 checks passed
@dedemorton
Copy link
Contributor

Whoops I guess it was set to automerge. I think that's Ok....

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2024
## Summary

Adds Synthetic Serverless doc links (and one missing logs link).

Closes elastic/obs-docs-team#219.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
(cherry picked from commit e7a9291)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2024
## Summary

Adds Synthetic Serverless doc links (and one missing logs link).

Closes elastic/obs-docs-team#219.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
(cherry picked from commit e7a9291)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.13
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@bmorelli25 bmorelli25 deleted the obs-doc-link-service branch May 8, 2024 17:57
kibanamachine added a commit that referenced this pull request May 8, 2024
# Backport

This will backport the following commits from `main` to `8.14`:
- [Add synthetic serverless doc links
(#182740)](#182740)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Brandon
Morelli","email":"brandon.morelli@elastic.co"},"sourceCommit":{"committedDate":"2024-05-08T17:09:49Z","message":"Add
synthetic serverless doc links (#182740)\n\n## Summary\r\n\r\nAdds
Synthetic Serverless doc links (and one missing logs
link).\r\n\r\nCloses
elastic/obs-docs-team#219:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
DeDe Morton
<dede.morton@elastic.co>","sha":"e7a9291bb97d7a3bdef947ed8f8c39d8cc4c3a56","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.13.0","v8.14.0","v8.15.0"],"title":"Add
synthetic serverless doc links
","number":182740,"url":"#182740
synthetic serverless doc links (#182740)\n\n## Summary\r\n\r\nAdds
Synthetic Serverless doc links (and one missing logs
link).\r\n\r\nCloses
elastic/obs-docs-team#219:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
DeDe Morton
<dede.morton@elastic.co>","sha":"e7a9291bb97d7a3bdef947ed8f8c39d8cc4c3a56"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","8.14"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182740
synthetic serverless doc links (#182740)\n\n## Summary\r\n\r\nAdds
Synthetic Serverless doc links (and one missing logs
link).\r\n\r\nCloses
elastic/obs-docs-team#219:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
DeDe Morton
<dede.morton@elastic.co>","sha":"e7a9291bb97d7a3bdef947ed8f8c39d8cc4c3a56"}}]}]
BACKPORT-->

Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
kibanamachine added a commit that referenced this pull request May 8, 2024
# Backport

This will backport the following commits from `main` to `8.13`:
- [Add synthetic serverless doc links
(#182740)](#182740)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Brandon
Morelli","email":"brandon.morelli@elastic.co"},"sourceCommit":{"committedDate":"2024-05-08T17:09:49Z","message":"Add
synthetic serverless doc links (#182740)\n\n## Summary\r\n\r\nAdds
Synthetic Serverless doc links (and one missing logs
link).\r\n\r\nCloses
elastic/obs-docs-team#219:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
DeDe Morton
<dede.morton@elastic.co>","sha":"e7a9291bb97d7a3bdef947ed8f8c39d8cc4c3a56","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.13.0","v8.14.0","v8.15.0"],"title":"Add
synthetic serverless doc links
","number":182740,"url":"#182740
synthetic serverless doc links (#182740)\n\n## Summary\r\n\r\nAdds
Synthetic Serverless doc links (and one missing logs
link).\r\n\r\nCloses
elastic/obs-docs-team#219:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
DeDe Morton
<dede.morton@elastic.co>","sha":"e7a9291bb97d7a3bdef947ed8f8c39d8cc4c3a56"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","8.14"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182740
synthetic serverless doc links (#182740)\n\n## Summary\r\n\r\nAdds
Synthetic Serverless doc links (and one missing logs
link).\r\n\r\nCloses
elastic/obs-docs-team#219:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
DeDe Morton
<dede.morton@elastic.co>","sha":"e7a9291bb97d7a3bdef947ed8f8c39d8cc4c3a56"}}]}]
BACKPORT-->

Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v8.13.0 v8.13.4 v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants