-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add synthetic serverless doc links #182740
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor issues.
tlsCertificate: `${OBSERVABILITY_DOCS}tls-certificate-alert.html`, | ||
uptimeDurationAnomaly: `${OBSERVABILITY_DOCS}duration-anomaly-alert.html`, | ||
monitorLogs: `${OBSERVABILITY_DOCS}monitor-logs.html`, | ||
monitorLogs: isServerless | ||
? `${SERVERLESS_OBSERVABILITY_DOCS}discover-and-explore-logs` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdbirnstiehl should confirm that this is the correct link (I'm not sure where the link appears in the UI).
Co-authored-by: DeDe Morton <dede.morton@elastic.co>
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming Mike likes the logging link.
Whoops I guess it was set to automerge. I think that's Ok.... |
## Summary Adds Synthetic Serverless doc links (and one missing logs link). Closes elastic/obs-docs-team#219. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: DeDe Morton <dede.morton@elastic.co> (cherry picked from commit e7a9291)
## Summary Adds Synthetic Serverless doc links (and one missing logs link). Closes elastic/obs-docs-team#219. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: DeDe Morton <dede.morton@elastic.co> (cherry picked from commit e7a9291)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.14`: - [Add synthetic serverless doc links (#182740)](#182740) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Brandon Morelli","email":"brandon.morelli@elastic.co"},"sourceCommit":{"committedDate":"2024-05-08T17:09:49Z","message":"Add synthetic serverless doc links (#182740)\n\n## Summary\r\n\r\nAdds Synthetic Serverless doc links (and one missing logs link).\r\n\r\nCloses elastic/obs-docs-team#219: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: DeDe Morton <dede.morton@elastic.co>","sha":"e7a9291bb97d7a3bdef947ed8f8c39d8cc4c3a56","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.13.0","v8.14.0","v8.15.0"],"title":"Add synthetic serverless doc links ","number":182740,"url":"#182740 synthetic serverless doc links (#182740)\n\n## Summary\r\n\r\nAdds Synthetic Serverless doc links (and one missing logs link).\r\n\r\nCloses elastic/obs-docs-team#219: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: DeDe Morton <dede.morton@elastic.co>","sha":"e7a9291bb97d7a3bdef947ed8f8c39d8cc4c3a56"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","8.14"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182740 synthetic serverless doc links (#182740)\n\n## Summary\r\n\r\nAdds Synthetic Serverless doc links (and one missing logs link).\r\n\r\nCloses elastic/obs-docs-team#219: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: DeDe Morton <dede.morton@elastic.co>","sha":"e7a9291bb97d7a3bdef947ed8f8c39d8cc4c3a56"}}]}] BACKPORT--> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
# Backport This will backport the following commits from `main` to `8.13`: - [Add synthetic serverless doc links (#182740)](#182740) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Brandon Morelli","email":"brandon.morelli@elastic.co"},"sourceCommit":{"committedDate":"2024-05-08T17:09:49Z","message":"Add synthetic serverless doc links (#182740)\n\n## Summary\r\n\r\nAdds Synthetic Serverless doc links (and one missing logs link).\r\n\r\nCloses elastic/obs-docs-team#219: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: DeDe Morton <dede.morton@elastic.co>","sha":"e7a9291bb97d7a3bdef947ed8f8c39d8cc4c3a56","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v8.13.0","v8.14.0","v8.15.0"],"title":"Add synthetic serverless doc links ","number":182740,"url":"#182740 synthetic serverless doc links (#182740)\n\n## Summary\r\n\r\nAdds Synthetic Serverless doc links (and one missing logs link).\r\n\r\nCloses elastic/obs-docs-team#219: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: DeDe Morton <dede.morton@elastic.co>","sha":"e7a9291bb97d7a3bdef947ed8f8c39d8cc4c3a56"}},"sourceBranch":"main","suggestedTargetBranches":["8.13","8.14"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182740 synthetic serverless doc links (#182740)\n\n## Summary\r\n\r\nAdds Synthetic Serverless doc links (and one missing logs link).\r\n\r\nCloses elastic/obs-docs-team#219: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: DeDe Morton <dede.morton@elastic.co>","sha":"e7a9291bb97d7a3bdef947ed8f8c39d8cc4c3a56"}}]}] BACKPORT--> Co-authored-by: Brandon Morelli <brandon.morelli@elastic.co>
Summary
Adds Synthetic Serverless doc links (and one missing logs link).
Closes https://github.com/elastic/obs-docs-team/issues/219.