[8.14] [Reporting/CSV] Resolve max_concurrent_shard_requests issue (#182536) #182742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…182536) ## Summary There has been a consistent failure in a Discover-related test set in the kibana-ES-serverless verification job, meaning that ES-Kibana compatibility has drifted. Error details: ``` + "Encountered an unknown error: status_exception + Root causes: + status_exception: Parameter validation failed for [/_search]: The http parameter [max_concurrent_shard_requests] (with value [5]) is not permitted when running in serverless mode" + "Encountered an error with the number of CSV rows generated fromthe search: expected rows were indeterminable, received 0." at Context.<anonymous> (reporting.ts:182:33) at processTicksAndRejections (node:internal/process/task_queues:95:5) at Object.apply (wrap_function.js:73:16) ``` This tracked back to a feature added for reporting awhile back, which created a config schema field for the `max_concurrent_shard_requests` parameter in the search queries: https://github.com/elastic/kibana/pull/170344/files#diff-7bceb37eef3761e1161cf04f41668dd9195bfac9fea36e734a230b5ed878a974 Most of the changes in this PR are in test code. I created "Test" which extend protected methods in the original classes. This was done to remove the `@ts-expect-errors` lines of code. (cherry picked from commit f51c5c9)
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: |
davismcphee
approved these changes
May 7, 2024
kertal
added a commit
that referenced
this pull request
May 8, 2024
Unskipping functional CSV export tests which work now due to the backport PR #182742
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.14:Questions ?
Please refer to the Backport tool documentation