Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDR Workflows][E2E] Unskip artifacts FTR #182787

Merged
merged 5 commits into from
May 8, 2024

Conversation

szwarckonrad
Copy link
Contributor

@szwarckonrad szwarckonrad commented May 7, 2024

closes #180493

I've noticed locally that the modal where we input the blocklist entries can sometimes get rerendered without any apparent reason. So, I've added a retry mechanism that, in case the input's value is not present, attempts to fill it out again.

Failure example:
https://buildkite.com/elastic/kibana-on-merge/builds/43629#018ed329-76ee-4512-aef6-5583b2cf830e

Flaky test runner:
x25 - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5871
x75 - https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5873

@szwarckonrad
Copy link
Contributor Author

/ci

@szwarckonrad
Copy link
Contributor Author

/ci

@szwarckonrad
Copy link
Contributor Author

/ci

@szwarckonrad szwarckonrad self-assigned this May 7, 2024
@szwarckonrad szwarckonrad added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.14.0 v8.15.0 and removed backport:skip This commit does not require backporting labels May 7, 2024
@szwarckonrad szwarckonrad marked this pull request as ready for review May 7, 2024 17:13
@szwarckonrad szwarckonrad requested a review from a team as a code owner May 7, 2024 17:13
@szwarckonrad szwarckonrad requested a review from pzl May 7, 2024 17:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@pzl pzl requested review from tomsonpl and removed request for pzl May 7, 2024 17:14
Copy link
Member

@ashokaditya ashokaditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!! 🚢 it!

@szwarckonrad szwarckonrad enabled auto-merge (squash) May 8, 2024 11:07
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

@szwarckonrad szwarckonrad merged commit db48aa0 into elastic:main May 8, 2024
17 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2024
closes elastic#180493

I've noticed locally that the modal where we input the blocklist entries
can sometimes get rerendered without any apparent reason. So, I've added
a retry mechanism that, in case the input's value is not present,
attempts to fill it out again.

Failure example:

https://buildkite.com/elastic/kibana-on-merge/builds/43629#018ed329-76ee-4512-aef6-5583b2cf830e

Flaky test runner:
x25 -
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5871
x75 -
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5873

(cherry picked from commit db48aa0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 8, 2024
# Backport

This will backport the following commits from `main` to `8.14`:
- [[EDR Workflows][E2E] Unskip artifacts FTR
(#182787)](#182787)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Konrad
Szwarc","email":"konrad.szwarc@elastic.co"},"sourceCommit":{"committedDate":"2024-05-08T12:17:10Z","message":"[EDR
Workflows][E2E] Unskip artifacts FTR (#182787)\n\ncloses
#180493 noticed
locally that the modal where we input the blocklist entries\r\ncan
sometimes get rerendered without any apparent reason. So, I've
added\r\na retry mechanism that, in case the input's value is not
present,\r\nattempts to fill it out again.\r\n\r\nFailure
example:\r\n\r\nhttps://buildkite.com/elastic/kibana-on-merge/builds/43629#018ed329-76ee-4512-aef6-5583b2cf830e\r\n\r\n\r\nFlaky
test runner:\r\nx25
-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5871\r\nx75
-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5873","sha":"db48aa03b45e25151705df61d556ff3f8e30351d","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","v8.14.0","v8.15.0"],"title":"[EDR Workflows][E2E] Unskip
artifacts
FTR","number":182787,"url":"#182787
Workflows][E2E] Unskip artifacts FTR (#182787)\n\ncloses
#180493 noticed
locally that the modal where we input the blocklist entries\r\ncan
sometimes get rerendered without any apparent reason. So, I've
added\r\na retry mechanism that, in case the input's value is not
present,\r\nattempts to fill it out again.\r\n\r\nFailure
example:\r\n\r\nhttps://buildkite.com/elastic/kibana-on-merge/builds/43629#018ed329-76ee-4512-aef6-5583b2cf830e\r\n\r\n\r\nFlaky
test runner:\r\nx25
-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5871\r\nx75
-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5873","sha":"db48aa03b45e25151705df61d556ff3f8e30351d"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182787
Workflows][E2E] Unskip artifacts FTR (#182787)\n\ncloses
#180493 noticed
locally that the modal where we input the blocklist entries\r\ncan
sometimes get rerendered without any apparent reason. So, I've
added\r\na retry mechanism that, in case the input's value is not
present,\r\nattempts to fill it out again.\r\n\r\nFailure
example:\r\n\r\nhttps://buildkite.com/elastic/kibana-on-merge/builds/43629#018ed329-76ee-4512-aef6-5583b2cf830e\r\n\r\n\r\nFlaky
test runner:\r\nx25
-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5871\r\nx75
-\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5873","sha":"db48aa03b45e25151705df61d556ff3f8e30351d"}}]}]
BACKPORT-->

Co-authored-by: Konrad Szwarc <konrad.szwarc@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.14.0 v8.15.0
Projects
None yet
6 participants