Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry Collection Manager] Use top-level cluster_uuid #182857

Merged

Conversation

afharo
Copy link
Member

@afharo afharo commented May 7, 2024

Summary

Speaking with Stack Monitoring folks, we noticed that we're looking for the cluster_uuid a level too deep unnecessarily.

Checklist

For maintainers

@afharo afharo added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels May 7, 2024
@afharo
Copy link
Member Author

afharo commented May 7, 2024

/ci

@afharo afharo self-assigned this May 7, 2024
@afharo afharo marked this pull request as ready for review May 7, 2024 18:45
@afharo afharo requested a review from a team as a code owner May 7, 2024 18:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

@afharo afharo enabled auto-merge (squash) May 7, 2024 20:16
@afharo afharo merged commit a98dda0 into elastic:main May 7, 2024
18 checks passed
@afharo afharo deleted the telemetry_collection_manager/use-top-cluster_uuid branch May 7, 2024 21:27
@afharo afharo added backport:prev-minor Backport to the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels May 13, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 13, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 13, 2024
…d` (#182857) (#183332)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Telemetry Collection Manager] Use top-level `cluster_uuid`
(#182857)](#182857)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2024-05-07T21:27:01Z","message":"[Telemetry
Collection Manager] Use top-level `cluster_uuid`
(#182857)","sha":"a98dda0f0672a5a373142bcdbcfcc9e72bb4209c","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Feature:Telemetry","release_note:skip","backport:prev-minor","v8.15.0"],"title":"[Telemetry
Collection Manager] Use top-level
`cluster_uuid`","number":182857,"url":"#182857
Collection Manager] Use top-level `cluster_uuid`
(#182857)","sha":"a98dda0f0672a5a373142bcdbcfcc9e72bb4209c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182857
Collection Manager] Use top-level `cluster_uuid`
(#182857)","sha":"a98dda0f0672a5a373142bcdbcfcc9e72bb4209c"}}]}]
BACKPORT-->

Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants