-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry Collection Manager] Use top-level cluster_uuid
#182857
Merged
afharo
merged 2 commits into
elastic:main
from
afharo:telemetry_collection_manager/use-top-cluster_uuid
May 7, 2024
Merged
[Telemetry Collection Manager] Use top-level cluster_uuid
#182857
afharo
merged 2 commits into
elastic:main
from
afharo:telemetry_collection_manager/use-top-cluster_uuid
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afharo
added
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Feature:Telemetry
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
labels
May 7, 2024
/ci |
Pinging @elastic/kibana-core (Team:Core) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @afharo |
Bamieh
approved these changes
May 7, 2024
2 tasks
afharo
added
backport:prev-minor
Backport to the previous minor version (i.e. one version back from main)
and removed
backport:skip
This commit does not require backporting
labels
May 13, 2024
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 13, 2024
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 13, 2024
…d` (#182857) (#183332) # Backport This will backport the following commits from `main` to `8.14`: - [[Telemetry Collection Manager] Use top-level `cluster_uuid` (#182857)](#182857) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alejandro Fernández Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2024-05-07T21:27:01Z","message":"[Telemetry Collection Manager] Use top-level `cluster_uuid` (#182857)","sha":"a98dda0f0672a5a373142bcdbcfcc9e72bb4209c","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Feature:Telemetry","release_note:skip","backport:prev-minor","v8.15.0"],"title":"[Telemetry Collection Manager] Use top-level `cluster_uuid`","number":182857,"url":"#182857 Collection Manager] Use top-level `cluster_uuid` (#182857)","sha":"a98dda0f0672a5a373142bcdbcfcc9e72bb4209c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182857 Collection Manager] Use top-level `cluster_uuid` (#182857)","sha":"a98dda0f0672a5a373142bcdbcfcc9e72bb4209c"}}]}] BACKPORT--> Co-authored-by: Alejandro Fernández Haro <alejandro.haro@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to the previous minor version (i.e. one version back from main)
Feature:Telemetry
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v8.14.0
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Speaking with Stack Monitoring folks, we noticed that we're looking for the
cluster_uuid
a level too deep unnecessarily.Checklist
For maintainers