-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Relax privileges for Integrations Settings & Config tab #182869
[Fleet] Relax privileges for Integrations Settings & Config tab #182869
Conversation
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
</p> | ||
</EuiFlexItem> | ||
</EuiFlexGroup> | ||
<FormattedMessage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small formatting (getting rid of extra space) and i18n fix for this callout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
💚 Build Succeeded
The CI Stats report is too large to be displayed here, check out the CI build annotation for this information. History
To update your PR or re-run it, just comment with: cc @jen-huang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
…tic#182869) ## Summary Resolves elastic#181131. This PR enforces the following privileges: - Read access to integrations to view Integration > Settings - `writeIntegrationPolicies` and all access to integrations to make changes in Integration > Settings (including marking an integration as auto-upgrade at API level) - Read access to integrations & access to add agents to view Integrations > Config (cherry picked from commit e048b86)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…g tab (#182869) (#182907) # Backport This will backport the following commits from `main` to `8.14`: - [[Fleet] Relax privileges for Integrations Settings & Config tab (#182869)](#182869) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jen Huang","email":"its.jenetic@gmail.com"},"sourceCommit":{"committedDate":"2024-05-08T07:54:58Z","message":"[Fleet] Relax privileges for Integrations Settings & Config tab (#182869)\n\n## Summary\r\n\r\nResolves #181131 PR enforces the following privileges:\r\n\r\n- Read access to integrations to view Integration > Settings\r\n- `writeIntegrationPolicies` and all access to integrations to make\r\nchanges in Integration > Settings (including marking an integration as\r\nauto-upgrade at API level)\r\n- Read access to integrations & access to add agents to view\r\nIntegrations > Config","sha":"e048b862f9243b0ffb65f81629f1d1ed6cf17c15","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.14.0","v8.15.0"],"title":"[Fleet] Relax privileges for Integrations Settings & Config tab","number":182869,"url":"#182869 Relax privileges for Integrations Settings & Config tab (#182869)\n\n## Summary\r\n\r\nResolves #181131 PR enforces the following privileges:\r\n\r\n- Read access to integrations to view Integration > Settings\r\n- `writeIntegrationPolicies` and all access to integrations to make\r\nchanges in Integration > Settings (including marking an integration as\r\nauto-upgrade at API level)\r\n- Read access to integrations & access to add agents to view\r\nIntegrations > Config","sha":"e048b862f9243b0ffb65f81629f1d1ed6cf17c15"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182869 Relax privileges for Integrations Settings & Config tab (#182869)\n\n## Summary\r\n\r\nResolves #181131 PR enforces the following privileges:\r\n\r\n- Read access to integrations to view Integration > Settings\r\n- `writeIntegrationPolicies` and all access to integrations to make\r\nchanges in Integration > Settings (including marking an integration as\r\nauto-upgrade at API level)\r\n- Read access to integrations & access to add agents to view\r\nIntegrations > Config","sha":"e048b862f9243b0ffb65f81629f1d1ed6cf17c15"}}]}] BACKPORT--> Co-authored-by: Jen Huang <its.jenetic@gmail.com>
Summary
Resolves #181131.
This PR enforces the following privileges:
writeIntegrationPolicies
and all access to integrations to make changes in Integration > Settings (including marking an integration as auto-upgrade at API level)