Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Relax privileges for Integrations Settings & Config tab #182869

Merged

Conversation

jen-huang
Copy link
Contributor

@jen-huang jen-huang commented May 7, 2024

Summary

Resolves #181131.

This PR enforces the following privileges:

  • Read access to integrations to view Integration > Settings
  • writeIntegrationPolicies and all access to integrations to make changes in Integration > Settings (including marking an integration as auto-upgrade at API level)
  • Read access to integrations & access to add agents to view Integrations > Config

@jen-huang jen-huang added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.14.0 v8.15.0 labels May 7, 2024
@jen-huang jen-huang self-assigned this May 7, 2024
@jen-huang jen-huang marked this pull request as ready for review May 7, 2024 18:19
@jen-huang jen-huang requested a review from a team as a code owner May 7, 2024 18:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

</p>
</EuiFlexItem>
</EuiFlexGroup>
<FormattedMessage
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting (getting rid of extra space) and i18n fix for this callout

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jen-huang jen-huang enabled auto-merge (squash) May 7, 2024 19:45
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

Copy link
Contributor

@criamico criamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@jen-huang jen-huang merged commit e048b86 into elastic:main May 8, 2024
19 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2024
…tic#182869)

## Summary

Resolves elastic#181131.

This PR enforces the following privileges:

- Read access to integrations to view Integration > Settings
- `writeIntegrationPolicies` and all access to integrations to make
changes in Integration > Settings (including marking an integration as
auto-upgrade at API level)
- Read access to integrations & access to add agents to view
Integrations > Config

(cherry picked from commit e048b86)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 8, 2024
…g tab (#182869) (#182907)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Fleet] Relax privileges for Integrations Settings &amp; Config tab
(#182869)](#182869)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jen
Huang","email":"its.jenetic@gmail.com"},"sourceCommit":{"committedDate":"2024-05-08T07:54:58Z","message":"[Fleet]
Relax privileges for Integrations Settings & Config tab (#182869)\n\n##
Summary\r\n\r\nResolves
#181131 PR enforces
the following privileges:\r\n\r\n- Read access to integrations to view
Integration > Settings\r\n- `writeIntegrationPolicies` and all access to
integrations to make\r\nchanges in Integration > Settings (including
marking an integration as\r\nauto-upgrade at API level)\r\n- Read access
to integrations & access to add agents to view\r\nIntegrations >
Config","sha":"e048b862f9243b0ffb65f81629f1d1ed6cf17c15","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.14.0","v8.15.0"],"title":"[Fleet]
Relax privileges for Integrations Settings & Config
tab","number":182869,"url":"#182869
Relax privileges for Integrations Settings & Config tab (#182869)\n\n##
Summary\r\n\r\nResolves
#181131 PR enforces
the following privileges:\r\n\r\n- Read access to integrations to view
Integration > Settings\r\n- `writeIntegrationPolicies` and all access to
integrations to make\r\nchanges in Integration > Settings (including
marking an integration as\r\nauto-upgrade at API level)\r\n- Read access
to integrations & access to add agents to view\r\nIntegrations >
Config","sha":"e048b862f9243b0ffb65f81629f1d1ed6cf17c15"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182869
Relax privileges for Integrations Settings & Config tab (#182869)\n\n##
Summary\r\n\r\nResolves
#181131 PR enforces
the following privileges:\r\n\r\n- Read access to integrations to view
Integration > Settings\r\n- `writeIntegrationPolicies` and all access to
integrations to make\r\nchanges in Integration > Settings (including
marking an integration as\r\nauto-upgrade at API level)\r\n- Read access
to integrations & access to add agents to view\r\nIntegrations >
Config","sha":"e048b862f9243b0ffb65f81629f1d1ed6cf17c15"}}]}]
BACKPORT-->

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
@jen-huang jen-huang deleted the fix/privilege/integration-settings branch May 8, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet]: Settings and Config tab for Integrations gets removed for user role Fleet Settings: "Read".
7 participants