[Security Solution][Timeline] - fix ESQL tab full screen showing unwanted UI elements #182876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeOberti
added
Team:Threat Hunting:Investigations
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
added
the
release_note:skip
kqualters-elastic
approved these changes
May 7, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 7, 2024
…nted UI elements (elastic#182876) (cherry picked from commit 0a355aa)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 8, 2024
…ng unwanted UI elements (#182876) (#182886) # Backport This will backport the following commits from `main` to `8.14`: - [[Security Solution][Timeline] - fix ESQL tab full screen showing unwanted UI elements (#182876)](#182876) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-05-07T21:31:59Z","message":"[Security Solution][Timeline] - fix ESQL tab full screen showing unwanted UI elements (#182876)","sha":"0a355aa0494739af9655f7786381d7eb84202f5c","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","v8.14.0","v8.15.0"],"title":"[Security Solution][Timeline] - fix ESQL tab full screen showing unwanted UI elements","number":182876,"url":"#182876 Solution][Timeline] - fix ESQL tab full screen showing unwanted UI elements (#182876)","sha":"0a355aa0494739af9655f7786381d7eb84202f5c"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182876 Solution][Timeline] - fix ESQL tab full screen showing unwanted UI elements (#182876)","sha":"0a355aa0494739af9655f7786381d7eb84202f5c"}}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a small issue when going to full screen mode on the new ES|QL tab.
The
kbn-unified-data-tableforces to unsetz-indexvalues (see here) but this is not applied to EUI portals which Timeline is.The small change added in this PR focuses on adding this back to the
dscPageBodyclass which is in our case is within the Timeline ES|QL tab.Before fix
Screen.Recording.2024-05-07.at.2.37.13.PM.mov
After fix
Screen.Recording.2024-05-07.at.2.35.45.PM.mov
I also verified that this didn't break the Discover page in Security Solution running in Serverless
Screen.Recording.2024-05-07.at.2.49.59.PM.mov
#182812