Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Fix overriding title when using inline Lens vis editor #182897

Merged
merged 2 commits into from
May 8, 2024
Merged

[Lens] Fix overriding title when using inline Lens vis editor #182897

merged 2 commits into from
May 8, 2024

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented May 8, 2024 •
edited by kibanamachine

Summary

This PR fixes an issue in the Lens on-the-fly popover editor, in which a visualization title would be overridden to InsXY.

fixes #182896

@nickofthyme nickofthyme requested a review from a team as a code owner May 8, 2024 00:29
@nickofthyme nickofthyme added backport:prev-minor Backport to the previous minor version (i.e. one version back from main) backport:all-open Backport to all branches that could still receive a release release_note:fix and removed backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels May 8, 2024
@nickofthyme nickofthyme changed the title fix: lens title bug [Lens] Fix overriding title when using inline Lens vis editor May 8, 2024
@nickofthyme nickofthyme added backport:prev-minor Backport to the previous minor version (i.e. one version back from main) and removed backport:all-open Backport to all branches that could still receive a release labels May 8, 2024
@nickofthyme nickofthyme added backport:all-open Backport to all branches that could still receive a release and removed backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels May 8, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.4MB 1.4MB -48.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickofthyme nickofthyme merged commit 44f458b into elastic:main May 8, 2024
19 checks passed
@nickofthyme nickofthyme deleted the fix-lens-title-bug branch May 8, 2024 19:45
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2024
@nickofthyme
[Lens] Fix overriding title when using inline Lens vis editor (elasti…
bf935a7 
…c#182897)

## Summary

This PR fixes an issue in the Lens on-the-fly popover editor, in which a
visualization title would be overridden to `InsXY`.

fixes elastic#182896

(cherry picked from commit 44f458b)
@kibanamachine kibanamachine mentioned this pull request May 8, 2024
Merged
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
❌ 7.17 Backport failed because of merge conflicts
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 182897

Questions ?

Please refer to the Backport tool documentation

@nickofthyme nickofthyme added backport:prev-minor Backport to the previous minor version (i.e. one version back from main) v8.13.4 and removed backport:all-open Backport to all branches that could still receive a release labels May 8, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2024
@nickofthyme
[Lens] Fix overriding title when using inline Lens vis editor (elasti…
bc5d345 
…c#182897)

## Summary

This PR fixes an issue in the Lens on-the-fly popover editor, in which a
visualization title would be overridden to `InsXY`.

fixes elastic#182896

(cherry picked from commit 44f458b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@nickofthyme nickofthyme mentioned this pull request May 8, 2024
Merged
@nickofthyme
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

nickofthyme added a commit to nickofthyme/kibana that referenced this pull request May 8, 2024
@nickofthyme
[Lens] Fix overriding title when using inline Lens vis editor (elasti…
0fbd98a 
…c#182897)

## Summary

This PR fixes an issue in the Lens on-the-fly popover editor, in which a
visualization title would be overridden to `InsXY`.

fixes elastic#182896

(cherry picked from commit 44f458b)
kibanamachine added a commit that referenced this pull request May 8, 2024
@kibanamachine @nickofthyme
[8.14] [Lens] Fix overriding title when using inline Lens vis editor (#…
6e804fd 
…182897) (#182993)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Lens] Fix overriding title when using inline Lens vis editor
(#182897)](#182897)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nick
Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2024-05-08T19:45:26Z","message":"[Lens]
Fix overriding title when using inline Lens vis editor (#182897)\n\n##
Summary\r\n\r\nThis PR fixes an issue in the Lens on-the-fly popover
editor, in which a\r\nvisualization title would be overridden to
`InsXY`.\r\n\r\nfixes
#182896","sha":"44f458be5a4fd5104be5c709747e8c55eaf88760","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","v8.15.0"],"title":"[Lens]
Fix overriding title when using inline Lens vis
editor","number":182897,"url":"#182897
Fix overriding title when using inline Lens vis editor (#182897)\n\n##
Summary\r\n\r\nThis PR fixes an issue in the Lens on-the-fly popover
editor, in which a\r\nvisualization title would be overridden to
`InsXY`.\r\n\r\nfixes
#182896","sha":"44f458be5a4fd5104be5c709747e8c55eaf88760"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182897
Fix overriding title when using inline Lens vis editor (#182897)\n\n##
Summary\r\n\r\nThis PR fixes an issue in the Lens on-the-fly popover
editor, in which a\r\nvisualization title would be overridden to
`InsXY`.\r\n\r\nfixes
#182896","sha":"44f458be5a4fd5104be5c709747e8c55eaf88760"}}]}]
BACKPORT-->

Co-authored-by: Nick Partridge <nicholas.partridge@elastic.co>
markov00 pushed a commit that referenced this pull request May 9, 2024
@nickofthyme
[8.13] [Lens] Fix overriding title when using inline Lens vis editor (#…
89e3acd 
…182897) (#182998)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Lens] Fix overriding title when using inline Lens vis editor
(#182897)](#182897)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nick
Partridge","email":"nicholas.partridge@elastic.co"},"sourceCommit":{"committedDate":"2024-05-08T19:45:26Z","message":"[Lens]
Fix overriding title when using inline Lens vis editor (#182897)\n\n##
Summary\r\n\r\nThis PR fixes an issue in the Lens on-the-fly popover
editor, in which a\r\nvisualization title would be overridden to
`InsXY`.\r\n\r\nfixes
#182896","sha":"44f458be5a4fd5104be5c709747e8c55eaf88760","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:prev-minor","v8.15.0","v8.13.4"],"number":182897,"url":"#182897
Fix overriding title when using inline Lens vis editor (#182897)\n\n##
Summary\r\n\r\nThis PR fixes an issue in the Lens on-the-fly popover
editor, in which a\r\nvisualization title would be overridden to
`InsXY`.\r\n\r\nfixes
#182896","sha":"44f458be5a4fd5104be5c709747e8c55eaf88760"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","labelRegex":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182897
Fix overriding title when using inline Lens vis editor (#182897)\n\n##
Summary\r\n\r\nThis PR fixes an issue in the Lens on-the-fly popover
editor, in which a\r\nvisualization title would be overridden to
`InsXY`.\r\n\r\nfixes
#182896","sha":"44f458be5a4fd5104be5c709747e8c55eaf88760"}},{"branch":"8.13","label":"v8.13.4","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"url":"#182993"}]}]
BACKPORT-->
@mistic mistic removed the v8.13.4 label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 left review comments

@stratoula stratoula stratoula left review comments

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) release_note:fix v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Ignores title when using on-the-fly popover
7 participants
@nickofthyme @kibana-ci @kibanamachine @dej611 @markov00 @stratoula @mistic