Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add await on deletion queries that are blowing up in FTR tests #182949

Merged
merged 1 commit into from
May 9, 2024

Conversation

delanni
Copy link
Contributor

@delanni delanni commented May 8, 2024

Summary

We've seen several cases of FTR tests dying of unhandled promise rejections. (https://buildkite.com/elastic/kibana-on-merge/builds/44936#018f56c3-184a-4cd6-98fc-4342d713e52a)

I've managed to locate the place where these requests come from - ideally with this addition, the tests should fail earlier, and not way after the test have been marked successful.

Further problems/questions:

  • The FTR runner should not mark these runs successful if there are unhandled promise rejections, rather wait for the promises to settle before concluding
  • Why did this call suddenly start to fail?

@delanni
Copy link
Contributor Author

delanni commented May 8, 2024

/ci

@delanni
Copy link
Contributor Author

delanni commented May 8, 2024

cc: @elastic/kibana-cloud-security-posture

@delanni delanni marked this pull request as ready for review May 8, 2024 16:18
@delanni delanni requested a review from a team as a code owner May 8, 2024 16:18
@delanni
Copy link
Contributor Author

delanni commented May 8, 2024

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@opauloh opauloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @delanni

We haven't spotted this as the FTR runner was marking these runs as successful as you pointed out, I saw we have other tests under x-pack/test/cloud_security_posture_api/routes with the same behavior, I am going to add an issue for us to handle that

@opauloh opauloh added the release_note:skip Skip the PR/issue when compiling release notes label May 8, 2024
@delanni delanni merged commit cc21a1a into elastic:main May 9, 2024
20 checks passed
@delanni delanni deleted the unhandled-rejections-2024-05-08 branch May 9, 2024 08:33
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants