-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Fixes value_lists_items
tests on MKI
#182950
Merged
MadameSheema
merged 5 commits into
elastic:main
from
MadameSheema:cypress/value-lists-fix
May 8, 2024
Merged
[Security Solution] Fixes value_lists_items
tests on MKI
#182950
MadameSheema
merged 5 commits into
elastic:main
from
MadameSheema:cypress/value-lists-fix
May 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/ci |
/ci |
MadameSheema
added
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Team:Detection Engine
Security Solution Detection Engine Area
v8.15.0
release_note:skip
Skip the PR/issue when compiling release notes
labels
May 8, 2024
Pinging @elastic/security-solution (Team: SecuritySolution) |
Pinging @elastic/security-detection-engine (Team:Detection Engine) |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
nkhristinin
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
Team:Detection Engine
Security Solution Detection Engine Area
Team: SecuritySolution
Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On MKI environments, the
can CRUD value list items
insidevalue_list_items
spec file is failing with the following error:This is because as part of the test we are asserting the name of the user that interacted with the value list. The username value is hardcoded as
system_indices_superuser
, that user is value on the the ESS Elasticsearch and stateless elasticsearch but does not exist on MKI environments.In this test we are fixing that, by checking first if we are triggering the test for an MKI environment, and if so, set the username appropriately.