Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Fixes value_lists_items tests on MKI #182950

Merged
merged 5 commits into from
May 8, 2024

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented May 8, 2024

Summary

On MKI environments, the can CRUD value list items inside value_list_items spec file is failing with the following error:

Expected to find content: 'Updated by: system_indices_superuse' within the element: <div.euiFlexGroup.css-1drqwgc-euiFlexGroup-responsive-l-flexStart-stretch-row> but never did.
Screenshot 2024-05-08 at 18 29 50

This is because as part of the test we are asserting the name of the user that interacted with the value list. The username value is hardcoded as system_indices_superuser, that user is value on the the ESS Elasticsearch and stateless elasticsearch but does not exist on MKI environments.

In this test we are fixing that, by checking first if we are triggering the test for an MKI environment, and if so, set the username appropriately.

@MadameSheema
Copy link
Member Author

/ci

@MadameSheema
Copy link
Member Author

/ci

@MadameSheema MadameSheema self-assigned this May 8, 2024
@MadameSheema MadameSheema added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area v8.15.0 release_note:skip Skip the PR/issue when compiling release notes labels May 8, 2024
@MadameSheema MadameSheema marked this pull request as ready for review May 8, 2024 16:35
@MadameSheema MadameSheema requested a review from a team as a code owner May 8, 2024 16:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@MadameSheema MadameSheema enabled auto-merge (squash) May 8, 2024 16:41
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@MadameSheema MadameSheema merged commit 4ded78d into elastic:main May 8, 2024
36 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants