Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-issue: remove PR owner from the GitHub issue content #182954

Merged
merged 1 commit into from
May 8, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented May 8, 2024

This will reduce the spam when the deployment happens

Summary

github-issue: remove PR owner from the GitHub issue content

This will reduce the spam when the deployment happens

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This will reduce the spam when the deployment happens
@v1v v1v added release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels May 8, 2024
@v1v v1v requested review from dgieselaar and a team May 8, 2024 14:20
@v1v v1v self-assigned this May 8, 2024
@v1v v1v requested a review from a team as a code owner May 8, 2024 14:21
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @v1v

@v1v v1v merged commit b7265d3 into elastic:main May 8, 2024
24 checks passed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 8, 2024
…182954)

This will reduce the spam when the deployment happens

(cherry picked from commit b7265d3)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 182954

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 9, 2024
…182954) (#182970)

# Backport

This will backport the following commits from `main` to `8.14`:
- [github-issue: remove PR owner from the GitHub issue content
(#182954)](#182954)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Victor
Martinez","email":"victormartinezrubio@gmail.com"},"sourceCommit":{"committedDate":"2024-05-08T15:49:20Z","message":"github-issue:
remove PR owner from the GitHub issue content (#182954)\n\nThis will
reduce the spam when the deployment
happens","sha":"b7265d39ce109d9489141053a50285874f0f30d1","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:all-open","v8.15.0"],"title":"github-issue:
remove PR owner from the GitHub issue
content","number":182954,"url":"#182954:
remove PR owner from the GitHub issue content (#182954)\n\nThis will
reduce the spam when the deployment
happens","sha":"b7265d39ce109d9489141053a50285874f0f30d1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#182954:
remove PR owner from the GitHub issue content (#182954)\n\nThis will
reduce the spam when the deployment
happens","sha":"b7265d39ce109d9489141053a50285874f0f30d1"}}]}]
BACKPORT-->

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes v8.14.0 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants