Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14] [ES|QL] remove quoted index name support (#182994) #183006

Merged
merged 1 commit into from
May 9, 2024

Conversation

drewdaemon
Copy link
Contributor

Backport

This will backport the following commits from main to 8.14:

Questions ?

Please refer to the Backport tool documentation

## Summary

The Kibana version of
elastic/elasticsearch#108431

Removes support for quoted index names.

Valid:
`from my_index`

Invalid
`from "my_index"`

<img width="514" alt="Screenshot 2024-05-08 at 2 10 24 PM"
src="https://github.com/elastic/kibana/assets/315764/f76f9128-cc13-41df-b885-b1ec30fe7ca3">
<img width="711" alt="Screenshot 2024-05-08 at 2 10 17 PM"
src="https://github.com/elastic/kibana/assets/315764/651c0480-ddcd-4f2b-ba05-862b3ca8a402">

(cherry picked from commit 34502a9)

# Conflicts:
#	packages/kbn-esql-ast/src/antlr/esql_lexer.interp
#	packages/kbn-esql-ast/src/antlr/esql_lexer.ts
#	packages/kbn-esql-ast/src/antlr/esql_parser.interp
#	packages/kbn-esql-ast/src/antlr/esql_parser.ts
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.2MB 3.2MB -311.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit a14ee25 into elastic:8.14 May 9, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants