Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14] [Security Solution] [Attack discovery] Removes the Attack discovery feature flag (#182975) #183017

Merged

Conversation

andrew-goldstein
Copy link
Contributor

Backport

This will backport the following commits from main to 8.14:

Questions ?

Please refer to the Backport tool documentation

…eature flag (elastic#182975)

## [Security Solution] [Attack discovery] Removes the Attack discovery feature flag

### Summary

This PR removes the feature flag required to enable the _Attack discovery_ feature.

It (always) enables the Attack discovery feature in both self managed and serverless deployments.

### Desk testing

1. REMOVE the `attackDiscoveryEnabled` feature flag if it was previously enabled in `kibana.dev.yml`:

```
# xpack.securitySolution.enableExperimental: ['attackDiscoveryEnabled']
```

2. Restart Kibana

3. Navigate to Security > Attack discovery

**Expected results**

- `Attack discovery` appears in the global navigation, below `Alerts`
- The contents of the `Attack discovery` page are displayed, per the self managed and serverless examples in the screenshots below:

![self_managed](https://github.com/elastic/kibana/assets/4459398/40d9c23c-af67-476b-997b-fca0ac1c5467)

_Above: Attack discovery in self managed_

![attack_discovery_serverless](https://github.com/elastic/kibana/assets/4459398/1dadcf1a-8a46-4bd5-8b78-df1135e5933f)

_Above: Attack discovery in serverless_

(cherry picked from commit 39fe68e)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 15.2MB 15.2MB -62.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 82.7KB 82.6KB -74.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @andrew-goldstein

@andrew-goldstein andrew-goldstein merged commit ef0c718 into elastic:8.14 May 9, 2024
38 checks passed
@andrew-goldstein andrew-goldstein deleted the backport/8.14/pr-182975 branch May 9, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants