Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Single Metric Viewer embeddable in dashboards: ensure edit to different job works as expected #183086

Merged
merged 1 commit into from
May 10, 2024
Merged

[ML] Single Metric Viewer embeddable in dashboards: ensure edit to different job works as expected #183086

merged 1 commit into from
May 10, 2024

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented May 9, 2024 •
edited by kibanamachine

Summary

Fixes #182756 (comment)

This PR ensures the loaded job and the selected job id are synced to ensure the chart loads correctly.

After:

SMVchartFix.mp4

@alvarezmelissa87 alvarezmelissa87 self-assigned this May 9, 2024
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner May 9, 2024 17:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 mentioned this pull request May 9, 2024
Merged
9 tasks
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.2MB 4.2MB +31.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

peteharverson
peteharverson approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

walterra
walterra approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@alvarezmelissa87 alvarezmelissa87 merged commit fa75c0e into elastic:main May 10, 2024
28 checks passed
@alvarezmelissa87 alvarezmelissa87 deleted the ml-smv-in-dashboard-fix branch May 10, 2024 14:37
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.14 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.14:
- [UII] Use local storage for tours in Fleet and Integrations (#183102)
- [MGMTXP] Fix tooltip text in Jira connector (#182358)
- [SLO] synthetics add fields to temp document (#181843)

Manual backport

To create the backport manually run:

node scripts/backport --pr 183086

Questions ?

Please refer to the Backport tool documentation

@alvarezmelissa87
Copy link
Contributor Author

Manual backport here #183179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v8.14.0 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alvarezmelissa87 @elasticmachine @kibana-ci @kibanamachine @walterra @peteharverson