Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing flaky ml test #183139

Merged
merged 1 commit into from May 10, 2024
Merged

Fixing flaky ml test #183139

merged 1 commit into from May 10, 2024

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented May 10, 2024

Summary

Closes #177215

Changing ML rule functional test to stop the transform first, then creating the rule. The rule runs when it is created and the test is testing for event.action: "open" which is written on a new alert, so we only want to rule to run once. Removed the unnecessary runSoon call.

Flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5929

@ymao1 ymao1 changed the title Flaky ml test Fixing flaky ml test May 10, 2024
@ymao1 ymao1 self-assigned this May 10, 2024
@ymao1 ymao1 added release_note:skip Skip the PR/issue when compiling release notes Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types v8.15.0 labels May 10, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 marked this pull request as ready for review May 10, 2024 18:57
@ymao1 ymao1 requested a review from a team as a code owner May 10, 2024 18:57
@ymao1 ymao1 requested a review from darnautov May 10, 2024 18:57
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1 ymao1 merged commit 57d5f93 into elastic:main May 10, 2024
25 checks passed
@ymao1 ymao1 deleted the flaky-ml-test branch May 10, 2024 20:55
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.14 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.14:
- [ML] Enable transform health rule API tests (#182560)

Manual backport

To create the backport manually run:

node scripts/backport --pr 183139

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types release_note:skip Skip the PR/issue when compiling release notes v8.14.0 v8.15.0
Projects
No open projects
5 participants