Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Obs Alerts > Rules][KEYBOARD]: Tooltips in the datagrid header must be keyboard accessible #183294

Merged
merged 4 commits into from
May 16, 2024

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 13, 2024

Closes: https://github.com/elastic/observability-dev/issues/3357

Description

The Obs Alert Rules view has a table with tooltips that cannot be reached by keyboard. These elements can be helpful to users to understand what the column represents, and must be available to all users. Screenshots attached below.

This ticket captures tooltips on the Rules and Logs tabs for compactness. Let me know if you need me to break these out to individual items.

Steps to recreate

  1. Open the Obs Alerts Rules table
  2. Click or tab to the rules table
  3. Tab through the Rules table

What was changed?:

  1. EuiToolTip was replaced to EuiIconTip

Screen:

Screen.Recording.2024-05-13.at.17.12.30.mov
Screen.Recording.2024-05-13.at.17.13.29.mov

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes v8.15.0 Project:Accessibility Team:Observability Team label for Observability Team (for things that are handled across all of observability) Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels May 13, 2024
@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp marked this pull request as ready for review May 14, 2024 09:48
@alexwizp alexwizp requested a review from a team as a code owner May 14, 2024 09:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elastic elastic deleted a comment from kibana-ci May 14, 2024
@alexwizp
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.6MB -174.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally, looks good 👍

image

@alexwizp alexwizp merged commit 72e3d3f into elastic:main May 16, 2024
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants