Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTR](data views) update common serverless api tests to use api keys #183386

Conversation

wayneseymour
Copy link
Member

@wayneseymour wayneseymour commented May 14, 2024

Use api keys for api calls, to act as the user, within: x-pack/test_serverless/api_integration/test_suites/common/data_views/

Contributes to: #180834

@wayneseymour wayneseymour self-assigned this May 14, 2024
@wayneseymour wayneseymour added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting labels May 14, 2024
@wayneseymour wayneseymour force-pushed the update-common-svrless-api-tests/data-views branch from 3dc2712 to 84279fd Compare May 14, 2024 10:54
@wayneseymour wayneseymour force-pushed the update-common-svrless-api-tests/data-views branch from 84279fd to 60e1f91 Compare May 16, 2024 16:16
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6015

[❌] x-pack/test_serverless/api_integration/test_suites/observability/common_configs/config.group1.ts: 0/2 tests passed.

see run history

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6016

[❌] x-pack/test_serverless/api_integration/test_suites/observability/common_configs/config.group1.ts: 0/2 tests passed.

see run history

@wayneseymour wayneseymour force-pushed the update-common-svrless-api-tests/data-views branch from bb4cdef to f93db86 Compare May 17, 2024 11:03
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6023

[❌] x-pack/test_serverless/api_integration/test_suites/observability/common_configs/config.group1.ts: 0/2 tests passed.

see run history

@wayneseymour
Copy link
Member Author

/ci

1 similar comment
@wayneseymour
Copy link
Member Author

/ci

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

1 similar comment
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

/ci

@wayneseymour wayneseymour force-pushed the update-common-svrless-api-tests/data-views branch from 24e3456 to 033310e Compare May 22, 2024 12:07
@wayneseymour wayneseymour force-pushed the update-common-svrless-api-tests/data-views branch from 033310e to 3369c2c Compare May 22, 2024 12:08
@wayneseymour
Copy link
Member Author

/ci

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6072

[✅] x-pack/test_serverless/api_integration/test_suites/search/common_configs/config.group1.ts: 5/5 tests passed.

see run history

@wayneseymour wayneseymour marked this pull request as ready for review May 22, 2024 16:48
@wayneseymour wayneseymour requested a review from a team as a code owner May 22, 2024 16:48
@wayneseymour wayneseymour marked this pull request as draft May 22, 2024 16:48
@wayneseymour wayneseymour marked this pull request as ready for review May 22, 2024 16:49
@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@wayneseymour
Copy link
Member Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look great and the tests pass! 🎉

Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvements

Copy link
Member

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wayneseymour wayneseymour merged commit 989549c into elastic:main May 24, 2024
18 checks passed
@wayneseymour wayneseymour deleted the update-common-svrless-api-tests/data-views branch May 24, 2024 09:26
rshen91 pushed a commit to rshen91/kibana that referenced this pull request May 30, 2024
…lastic#183386)

Use api keys for api calls, to act as the user, within:
`x-pack/test_serverless/api_integration/test_suites/common/data_views/`

Contributes to: elastic#180834

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants