-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Connection Details] Cloud ID info "?" icon with popup #183388
[Connection Details] Cloud ID info "?" icon with popup #183388
Conversation
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
Pinging @elastic/appex-sharedux (Team:SharedUX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not test locally, and we may want some SharedUX review to sanity check the pattern (although you are ex-Shared UX ;) ), but overall LGTM!
@@ -35,6 +35,7 @@ const createOpts = async (props: KibanaConnectionDetailsProviderProps) => { | |||
endpoints: { | |||
id: start.plugins?.cloud?.cloudId, | |||
url: start.plugins?.cloud?.elasticsearchUrl, | |||
cloudIdLearMoreLink: docLinks?.links?.cloud?.beatsAndLogstashConfiguration, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cloudIdLearMoreLink: docLinks?.links?.cloud?.beatsAndLogstashConfiguration, | |
cloudIdLearnMoreLink: docLinks?.links?.cloud?.beatsAndLogstashConfiguration, |
Summary
Cloud ID copy input now has a information "?" icon with a popup and a link.
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Release note
Cloud ID copy input now has a information "?" icon with a popup and a link.