Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Connection Details] Cloud ID info "?" icon with popup #183388

Merged
merged 4 commits into from
May 16, 2024

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented May 14, 2024

Summary

Cloud ID copy input now has a information "?" icon with a popup and a link.

image

image

cloud-id-popover

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Release note

Cloud ID copy input now has a information "?" icon with a popup and a link.

cloud-id-popover

@vadimkibana vadimkibana requested a review from a team as a code owner May 14, 2024 10:57
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudLinks 75 77 +2
home 266 268 +2
total +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
home 148.0KB 149.3KB +1.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudLinks 25.3KB 26.6KB +1.3KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana added review release_note:feature Makes this part of the condensed release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.15.0 labels May 15, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@vadimkibana vadimkibana changed the title [wip] Connection details info popup [Connection Details] Cloud ID info "?" icon with popup May 15, 2024
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test locally, and we may want some SharedUX review to sanity check the pattern (although you are ex-Shared UX ;) ), but overall LGTM!

@@ -35,6 +35,7 @@ const createOpts = async (props: KibanaConnectionDetailsProviderProps) => {
endpoints: {
id: start.plugins?.cloud?.cloudId,
url: start.plugins?.cloud?.elasticsearchUrl,
cloudIdLearMoreLink: docLinks?.links?.cloud?.beatsAndLogstashConfiguration,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cloudIdLearMoreLink: docLinks?.links?.cloud?.beatsAndLogstashConfiguration,
cloudIdLearnMoreLink: docLinks?.links?.cloud?.beatsAndLogstashConfiguration,

@vadimkibana vadimkibana merged commit ece10c6 into elastic:main May 16, 2024
45 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes review Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants