Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTR] Session Concurrency Test #183409

Merged
merged 1 commit into from
May 17, 2024

Conversation

elena-shostak
Copy link
Contributor

@elena-shostak elena-shostak commented May 14, 2024

Summary

Set security.session.cleanupInterval to 5h for session concurrency test.

Prerequisites

Hypothesis

Taking into consideration that:

  • session_cleanup task is not the only one scheduled during test run.
  • There is sort of an exponential backoff implemented for task polling if there are too many retries.
  • Clock jitter.

I had a hypothesis that if our whole test run exceeds 1h or polling interval gets adjusted because of retries we might end up executing the scheduled cleanup before we trigger runCleanupTaskSoon (this is there we drop 1 session already).

FTR runs (x55 each)

  • cleanupInterval set to 5h: #1 🟢, #2 🟢
  • cleanupInterval set to default 1h: #1 🟢, #2 🔴 (has 2 failures out of 55)

Checklist

For maintainers

Fixes: #149091

@elena-shostak elena-shostak added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! release_note:skip Skip the PR/issue when compiling release notes FTR Feature:Security/Session Management Platform Security - Session Management labels May 16, 2024
@elena-shostak
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elena-shostak elena-shostak marked this pull request as ready for review May 16, 2024 12:50
@elena-shostak elena-shostak requested a review from a team as a code owner May 16, 2024 12:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elena-shostak elena-shostak changed the title Session concurrency test [FTR] Session Concurrency Test May 16, 2024
@elena-shostak elena-shostak merged commit a74d12c into elastic:main May 17, 2024
17 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Security/Session Management Platform Security - Session Management FTR release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.15.0
Projects
None yet
5 participants