[Security Solution] Fix TopN filters in timeline #183501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semd
added
release_note:skip
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
|
Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore) |
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @semd |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 16, 2024
## Summary Fixes: elastic#183497 Sets the `applyGlobalQueriesAndFilters` prop correctly to _VisualizationEmbeddable_. This property was ignored when used from the _TopN_ component, causing it to always apply the global filters and query. Extra: I cleaned all props that are not used in those component ### Screenshots Pre-condition: Setting `user.name:"0q3c5et718"` query to the global query in the background. Before:  After:  --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 5acea44)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 16, 2024
…83601) # Backport This will backport the following commits from `main` to `8.14`: - [[Security Solution] Fix TopN filters in timeline (#183501)](#183501) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sergi Massaneda","email":"sergi.massaneda@elastic.co"},"sourceCommit":{"committedDate":"2024-05-16T08:45:31Z","message":"[Security Solution] Fix TopN filters in timeline (#183501)\n\n## Summary\r\n\r\nFixes: #183497 the `applyGlobalQueriesAndFilters` prop correctly to\r\n_VisualizationEmbeddable_. This property was ignored when used from the\r\n_TopN_ component, causing it to always apply the global filters and\r\nquery.\r\n\r\nExtra: I cleaned all props that are not used in those component\r\n\r\n### Screenshots\r\n\r\nPre-condition: Setting `user.name:\"0q3c5et718\"` query to the global\r\nquery in the background.\r\n\r\nBefore:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"5acea44cc9b9694e52534e584ee68187ef8760c1","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting","Team:Threat Hunting:Explore","v8.14.0","v8.15.0"],"title":"[Security Solution] Fix TopN filters in timeline","number":183501,"url":"#183501 Solution] Fix TopN filters in timeline (#183501)\n\n## Summary\r\n\r\nFixes: #183497 the `applyGlobalQueriesAndFilters` prop correctly to\r\n_VisualizationEmbeddable_. This property was ignored when used from the\r\n_TopN_ component, causing it to always apply the global filters and\r\nquery.\r\n\r\nExtra: I cleaned all props that are not used in those component\r\n\r\n### Screenshots\r\n\r\nPre-condition: Setting `user.name:\"0q3c5et718\"` query to the global\r\nquery in the background.\r\n\r\nBefore:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"5acea44cc9b9694e52534e584ee68187ef8760c1"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183501 Solution] Fix TopN filters in timeline (#183501)\n\n## Summary\r\n\r\nFixes: #183497 the `applyGlobalQueriesAndFilters` prop correctly to\r\n_VisualizationEmbeddable_. This property was ignored when used from the\r\n_TopN_ component, causing it to always apply the global filters and\r\nquery.\r\n\r\nExtra: I cleaned all props that are not used in those component\r\n\r\n### Screenshots\r\n\r\nPre-condition: Setting `user.name:\"0q3c5et718\"` query to the global\r\nquery in the background.\r\n\r\nBefore:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"5acea44cc9b9694e52534e584ee68187ef8760c1"}}]}] BACKPORT--> Co-authored-by: Sergi Massaneda <sergi.massaneda@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #183497
Sets the
applyGlobalQueriesAndFiltersprop correctly to VisualizationEmbeddable. This property was ignored when used from the TopN component, causing it to always apply the global filters and query.Extra: I cleaned all props that are not used in those component
Screenshots
Pre-condition: Setting
user.name:"0q3c5et718"query to the global query in the background.Before:
After: