[Solution nav] Prevent href click on accordion button #183508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ci |
sebelga
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
|
Tested locally and works. I was able to get the tests to pass as well by using navId here after giving the child link an ID to distinguish it from the parent link id. Thank you! |
neptunian
approved these changes
May 15, 2024
Dosant
approved these changes
May 16, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.15.0
backport:skip
neptunian
added a commit
that referenced
this pull request
May 16, 2024
## Summary Currently the breadcrumb of the parent navigation item isn't a link: <img width="339" alt="Screenshot 2024-05-10 at 2 06 42 PM" src="https://github.com/elastic/kibana/assets/1676003/1471125f-59d7-468e-8ede-3a3c3c3e42dc"> This change makes it so the breadcrumb of parent navigation item is linkable: <img width="293" alt="Screenshot 2024-05-10 at 2 21 27 PM" src="https://github.com/elastic/kibana/assets/1676003/aad5e650-33e1-419d-b866-0b7ec70e1f42"> The links will go to the first item in the list of child links. The merging of this PR depends on #183508 allows for this functionality to work without making the left side parent collapsible link, also a href link - only the breadcrumb. ## Testing - Start a serverless kibana instance - Navigate to a child link of an accordion using the left side navigation <img width="589" alt="Screenshot 2024-05-15 at 11 26 24 AM" src="https://github.com/elastic/kibana/assets/1676003/d225967d-37d1-4f19-b3f5-856fcc1bce68"> - The breadcrumb should of this page should be a link and link you to the first child link of the accordion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I've added support for
hrefvalue to the accordion header button required to fix https://github.com/elastic/observability-serverless/issues/24.With the changes of this PR it is now possible to declare a
linkto an accordion parent, ant not have it affect the accordion toggle on/off behaviour. The link is then only used for the Breadcrumb.Manual testing
To test manually the change, apply the diff from here https://github.com/elastic/kibana/pull/183189/files and launch serverless observability. You should have the breadcrumb parent.