Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Obs Alerts > Rules][KEYBOARD]: Inspect Alerts Table button should always be visible and must be visible on keyboard focus #183513

Merged
merged 2 commits into from
May 16, 2024

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented May 15, 2024

Closes: https://github.com/elastic/observability-dev/issues/3361

Description

The Obs Alerts have a button for opening an Inspect Alerts table modal that is only visible on :hover. This button is easily missed by keyboard navigation because it is not visible on :focus. My recommendation is the button should always be visible and must be visible when it receives focus. Screenshot attached below.

Steps to recreate

  1. Open the Obs Alerts table
  2. Create an alert that's sure to fire, like a custom threshold that's very low, like 100 or 1000 documents
  3. Run the alert rule from the Rules view
  4. When the alert appears in Alerts, tab through to the data grid
  5. Watch closely for focus to "disappear"
  6. Press Tab again and focus should reappear
  7. Now press Shift + Tab to make focus disappear again
  8. Press Enter and verify the modal opens

What was done?:

  1. &:focus-visible styles were added to correctly handle keyboard navigation

Screen:

Screen.Recording.2024-05-15.at.16.33.54.mov

@alexwizp alexwizp added Project:Accessibility Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) release_note:skip Skip the PR/issue when compiling release notes v8.15.0 Team:Observability Team label for Observability Team (for things that are handled across all of observability) labels May 15, 2024
@alexwizp
Copy link
Contributor Author

/ci

@alexwizp
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.6MB +94.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alexwizp alexwizp marked this pull request as ready for review May 15, 2024 16:35
@alexwizp alexwizp requested a review from a team as a code owner May 15, 2024 16:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@alexwizp alexwizp merged commit f5c2cba into elastic:main May 16, 2024
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Team:Observability Team label for Observability Team (for things that are handled across all of observability) Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants