fix: [Obs Alerts > Rules][KEYBOARD]: Inspect Alerts Table button should always be visible and must be visible on keyboard focus #183513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://github.com/elastic/observability-dev/issues/3361
Description
The Obs Alerts have a button for opening an
Inspect Alerts table
modal that is only visible on:hover
. This button is easily missed by keyboard navigation because it is not visible on:focus
. My recommendation is the button should always be visible and must be visible when it receives focus. Screenshot attached below.Steps to recreate
Rules
viewAlerts
, tab through to the data gridTab
again and focus should reappearShift + Tab
to make focus disappear againEnter
and verify the modal opensWhat was done?:
&:focus-visible
styles were added to correctly handle keyboard navigationScreen:
Screen.Recording.2024-05-15.at.16.33.54.mov