Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Share Modal ]fix flaky test #183679

Merged
merged 9 commits into from
May 23, 2024
Merged

[Share Modal ]fix flaky test #183679

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5a14b32
fix flaky test
rshen91 May 16, 2024
5d181ae
Merge branch 'main' into fix-flaky-test
rshen91 May 20, 2024
6794c97
Merge branch 'main' into fix-flaky-test
rshen91 May 20, 2024
7cbe55b
Merge branch 'main' into fix-flaky-test
rshen91 May 20, 2024
bff9976
Merge branch 'main' into fix-flaky-test
rshen91 May 22, 2024
4c19d17
Merge remote-tracking branch 'upstream/main' into fix-flaky-test
rshen91 May 22, 2024
a8dadd2
remove conditional
rshen91 May 22, 2024
7c9447c
Merge remote-tracking branch 'upstream/main' into fix-flaky-test
rshen91 May 22, 2024
271f079
Merge remote-tracking branch 'origin/fix-flaky-test' into fix-flaky-test
rshen91 May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/dashboard/group3/reporting/screenshots.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ export default function ({
});
});

// FLAKY: https://github.com/elastic/kibana/issues/183566
describe.skip('Preserve Layout', () => {
before(async () => {
await loadEcommerce();
Expand All @@ -172,10 +171,10 @@ export default function ({
await PageObjects.dashboard.loadSavedDashboard('Ecom Dashboard');
await PageObjects.reporting.openExportTab();
await PageObjects.reporting.clickGenerateReportButton();
await PageObjects.share.closeShareModal();

const url = await PageObjects.reporting.getReportURL(60000);
const res = await PageObjects.reporting.getResponse(url ?? '');
await PageObjects.share.closeShareModal();

expect(res.status).to.equal(200);
expect(res.get('content-type')).to.equal('application/pdf');
Expand Down