Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Change update dataview #183789

Merged
merged 6 commits into from
May 22, 2024
Merged

[Cloud Security] Change update dataview #183789

merged 6 commits into from
May 22, 2024

Conversation

animehart
Copy link
Contributor

@animehart animehart commented May 17, 2024 •
edited by kibanamachine
Loading

Summary

Removing Update logic for Findings table from Client Side as well as overriding table column name

@animehart
Copy link
Contributor Author

/ci

@animehart
Copy link
Contributor Author

/ci

@animehart
Copy link
Contributor Author

/ci

@animehart
Copy link
Contributor Author

/ci

@animehart animehart linked an issue May 22, 2024 that may be closed by this pull request
[Cloud Security] Remove DataView labels update logic and override table columns instead #172615
Closed
5 tasks
@animehart animehart changed the title Change update dataview [Cloud Security] Change update dataview May 22, 2024
@animehart animehart marked this pull request as ready for review May 22, 2024 09:05
@animehart animehart requested a review from a team as a code owner May 22, 2024 09:05
@animehart animehart added v8.15.0 release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related labels May 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 448.7KB 446.4KB -2.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

opauloh
opauloh approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@opauloh opauloh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally - LGTM

Worth noting that after this change is merged the tables won't have the custom naming by default anymore as the UnifiedDataTable does not support custom column naming, only DataView naming. Please create a follow-up ticket to add custom column naming support (Independent from the DataView) to the UnifiedDataTable component.

@animehart animehart merged commit 9cb7940 into elastic:main May 22, 2024
18 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 22, 2024
@animehart animehart mentioned this pull request May 23, 2024
Closed
2 tasks
rshen91 pushed a commit to rshen91/kibana that referenced this pull request May 30, 2024
@animehart @rshen91
[Cloud Security] Change update dataview (elastic#183789)
a203d32 
## Summary

Removing Update logic for Findings table from Client Side as well as
overriding table column name
@animehart animehart added backport and removed backport:skip This commit does not require backporting labels Jun 17, 2024
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 17, 2024
@animehart animehart added v8.13.5 v8.14.2 and removed backport:skip This commit does not require backporting labels Jun 17, 2024
@animehart animehart added backport:prev-minor Backport to the previous minor version (i.e. one version back from main) and removed v8.13.5 backport labels Jun 17, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 17, 2024
@animehart
[Cloud Security] Change update dataview (elastic#183789)
a1c039a 
## Summary

Removing Update logic for Findings table from Client Side as well as
overriding table column name

(cherry picked from commit 9cb7940)
@kibanamachine kibanamachine mentioned this pull request Jun 17, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 17, 2024
@kibanamachine @animehart
[8.14] [Cloud Security] Change update dataview (#183789) (#186327)
8fb9cb8 
# Backport

This will backport the following commits from `main` to `8.14`:
- [[Cloud Security] Change update dataview
(#183789)](#183789)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Rickyanto
Ang","email":"rickyangwyn@gmail.com"},"sourceCommit":{"committedDate":"2024-05-22T21:10:38Z","message":"[Cloud
Security] Change update dataview (#183789)\n\n## Summary\r\n\r\nRemoving
Update logic for Findings table from Client Side as well
as\r\noverriding table column
name","sha":"9cb7940601af359c624d70f6ff158f5e156f5861","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud
Security","backport:prev-minor","v8.15.0","v8.14.2"],"title":"[Cloud
Security] Change update
dataview","number":183789,"url":"#183789
Security] Change update dataview (#183789)\n\n## Summary\r\n\r\nRemoving
Update logic for Findings table from Client Side as well
as\r\noverriding table column
name","sha":"9cb7940601af359c624d70f6ff158f5e156f5861"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#183789
Security] Change update dataview (#183789)\n\n## Summary\r\n\r\nRemoving
Update logic for Findings table from Client Side as well
as\r\noverriding table column
name","sha":"9cb7940601af359c624d70f6ff158f5e156f5861"}},{"branch":"8.14","label":"v8.14.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: Rickyanto Ang <rickyangwyn@gmail.com>
@animehart animehart added v8.13.5 backport:prev-minor Backport to the previous minor version (i.e. one version back from main) and removed backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Jun 20, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 20, 2024
@animehart
[Cloud Security] Change update dataview (elastic#183789)
972e3a2 
## Summary

Removing Update logic for Findings table from Client Side as well as
overriding table column name

(cherry picked from commit 9cb7940)
@kibanamachine kibanamachine mentioned this pull request Jun 20, 2024
Closed
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
✅ 8.13
❌ 8.14 Cherrypick failed because the selected commit (9cb7940) is empty. It looks like the commit was already backported in #186327

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 183789

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 21, 2024
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

4 similar comments
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 3, 2024
@szaffarano szaffarano mentioned this pull request Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opauloh opauloh opauloh approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.13.5 v8.14.2 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud Security] Remove DataView labels update logic and override table columns instead
5 participants
@animehart @elasticmachine @kibana-ci @kibanamachine @opauloh