[Search] Add sync status to connector page #184024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Sync status to connector page. Adds a marker for content/access control sync buttons when last sync failed. Changes logic to show error message to make sure access control errors aren't lost. Fixes incomplete connector query to show correct counts on list.
efegurkan
added
bug
TattdCodeMonkey
approved these changes
May 22, 2024
| @@ -52,17 +60,23 @@ export function connectorStatusToText( | |||
| } | |||
|
|
|||
| export function connectorStatusToColor( | |||
| connectorStatus: ConnectorStatus, | |||
| connector: Connector, | |||
| hasIndexName: boolean | |||
There was a problem hiding this comment.
Since we're passing the whole connector now instead of just the status should we remove this parameter and just do the !!connector?.index_name in the function?
There was a problem hiding this comment.
Yes! I saw that and forgot to change. Will update and merge after
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 27, 2024
## Summary Adds Sync status to connector page. Adds a marker for content/access control sync buttons when last sync failed. Changes logic to show error message to make sure access control errors aren't lost. Fixes incomplete connector query to show correct counts on list. <img width="1593" alt="Screenshot 2024-05-22 at 16 01 27" src="https://github.com/elastic/kibana/assets/1410658/6e9fd843-7db1-42f3-9635-aab8efc7ecac"> <img width="1581" alt="Screenshot 2024-05-22 at 16 03 12" src="https://github.com/elastic/kibana/assets/1410658/d188c983-376c-4cae-96b5-560eebf4c93b"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 97e1206)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
May 27, 2024
# Backport This will backport the following commits from `main` to `8.14`: - [[Search] Add sync status to connector page (#184024)](#184024) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Efe Gürkan YALAMAN","email":"efeguerkan.yalaman@elastic.co"},"sourceCommit":{"committedDate":"2024-05-27T14:56:52Z","message":"[Search] Add sync status to connector page (#184024)\n\n## Summary\r\n\r\nAdds Sync status to connector page.\r\nAdds a marker for content/access control sync buttons when last sync\r\nfailed.\r\nChanges logic to show error message to make sure access control errors\r\naren't lost.\r\nFixes incomplete connector query to show correct counts on list.\r\n\r\n<img width=\"1593\" alt=\"Screenshot 2024-05-22 at 16 01 27\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1410658/6e9fd843-7db1-42f3-9635-aab8efc7ecac\">\r\n<img width=\"1581\" alt=\"Screenshot 2024-05-22 at 16 03 12\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1410658/d188c983-376c-4cae-96b5-560eebf4c93b\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"97e1206299d176e81c003c1c3e6a4898e1adb1b0","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:EnterpriseSearch","v8.14.0","v8.15.0"],"title":"[Search] Add sync status to connector page","number":184024,"url":"#184024 Add sync status to connector page (#184024)\n\n## Summary\r\n\r\nAdds Sync status to connector page.\r\nAdds a marker for content/access control sync buttons when last sync\r\nfailed.\r\nChanges logic to show error message to make sure access control errors\r\naren't lost.\r\nFixes incomplete connector query to show correct counts on list.\r\n\r\n<img width=\"1593\" alt=\"Screenshot 2024-05-22 at 16 01 27\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1410658/6e9fd843-7db1-42f3-9635-aab8efc7ecac\">\r\n<img width=\"1581\" alt=\"Screenshot 2024-05-22 at 16 03 12\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1410658/d188c983-376c-4cae-96b5-560eebf4c93b\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"97e1206299d176e81c003c1c3e6a4898e1adb1b0"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/184024","number":184024,"mergeCommit":{"message":"[Search] Add sync status to connector page (#184024)\n\n## Summary\r\n\r\nAdds Sync status to connector page.\r\nAdds a marker for content/access control sync buttons when last sync\r\nfailed.\r\nChanges logic to show error message to make sure access control errors\r\naren't lost.\r\nFixes incomplete connector query to show correct counts on list.\r\n\r\n<img width=\"1593\" alt=\"Screenshot 2024-05-22 at 16 01 27\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1410658/6e9fd843-7db1-42f3-9635-aab8efc7ecac\">\r\n<img width=\"1581\" alt=\"Screenshot 2024-05-22 at 16 03 12\"\r\nsrc=\"https://github.com/elastic/kibana/assets/1410658/d188c983-376c-4cae-96b5-560eebf4c93b\">\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"97e1206299d176e81c003c1c3e6a4898e1adb1b0"}}]}] BACKPORT--> Co-authored-by: Efe Gürkan YALAMAN <efeguerkan.yalaman@elastic.co>
rshen91
pushed a commit
to rshen91/kibana
that referenced
this pull request
May 30, 2024
## Summary Adds Sync status to connector page. Adds a marker for content/access control sync buttons when last sync failed. Changes logic to show error message to make sure access control errors aren't lost. Fixes incomplete connector query to show correct counts on list. <img width="1593" alt="Screenshot 2024-05-22 at 16 01 27" src="https://github.com/elastic/kibana/assets/1410658/6e9fd843-7db1-42f3-9635-aab8efc7ecac"> <img width="1581" alt="Screenshot 2024-05-22 at 16 03 12" src="https://github.com/elastic/kibana/assets/1410658/d188c983-376c-4cae-96b5-560eebf4c93b"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds Sync status to connector page.
Adds a marker for content/access control sync buttons when last sync failed.
Changes logic to show error message to make sure access control errors aren't lost.
Fixes incomplete connector query to show correct counts on list.
Checklist
Delete any items that are not applicable to this PR.