Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Add DLS parameters in native Outlook connector #184098

Merged
merged 4 commits into from
May 27, 2024

Conversation

parthpuri-elastic
Copy link
Contributor

Summary

Related to elastic/connectors#2405

Add new config parameter in Outlook Connector related to Document Level Security

Checklist

Delete any items that are not applicable to this PR.

For maintainers

Version: 8.15.0

@parthpuri-elastic parthpuri-elastic requested a review from a team as a code owner May 23, 2024 09:43
ui_restrictions: [],
validations: [],
value: false,
},
},
features: {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not mistaken we should add the feature flag as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, added.

@efegurkan efegurkan added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0 labels May 23, 2024
@efegurkan efegurkan changed the title Add DLS parameters in native Outlook connector [Search] Add DLS parameters in native Outlook connector May 23, 2024
@parthpuri-elastic
Copy link
Contributor Author

buildkite test this

@efegurkan efegurkan enabled auto-merge (squash) May 27, 2024 13:57
@efegurkan efegurkan merged commit a392e59 into elastic:main May 27, 2024
22 of 23 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 27, 2024
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #8 / Index Management APIs Inference endpoints "before all" hook in "Inference endpoints"

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/search-connectors 3673 3689 +16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.7MB 2.7MB +350.0B
serverlessSearch 474.2KB 474.3KB +153.0B
total +503.0B
Unknown metric groups

API count

id before after diff
@kbn/search-connectors 3673 3689 +16

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

rshen91 pushed a commit to rshen91/kibana that referenced this pull request May 30, 2024
## Summary

Related to elastic/connectors#2405

Add new config parameter in Outlook Connector related to Document Level
Security

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Version: 8.15.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants