[ResponseOps][Cases] Allow users to create templates #184104

js-jankisalvi · 2024-05-23T11:39:01Z

Summary

Merging into feature branch.

Implements create functionality #181864

Add template from case settings page.

How to test

Go to Cases > Settings
Click on add templates
Fill the form
Save

Scenarios:

Create template with different custom fields
Create template with connector

Flaky test runner here

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

…-templates-ui

elasticmachine · 2024-05-30T17:02:03Z

Pinging @elastic/response-ops (Team:ResponseOps)

elasticmachine · 2024-05-30T17:02:04Z

Pinging @elastic/response-ops-cases (Feature:Cases)

cnasikas

No code review. I tested the UI first. I will test the code soon. Finding:

I noticed that the template tags field provides options coming from the cases tags. Given that the tags are related to tags I think we should provide them from the template tags. We have all tags from all templates in the configuration. No need for an API call. Do we have a limit on the total number of tags per template?

The description is a text field. I think it should be a text area or markdown editor. Let's start with a text area for this MVP.
The description is required. What about making it optional?

The description is persisted to local storage. Given that this is a flyout and not a page I think we should not persist it. Otherwise, every time I open the flyout the description of the template I created previously will appear.

js-jankisalvi · 2024-05-31T09:47:57Z

I noticed that the template tags field provides options coming from the cases tags. Given that the tags are related to tags I think we should provide them from the template tags. We have all tags from all templates in the configuration. No need for an API call.

Ahh, good point. Will load the template tags here.

Do we have a limit on the total number of tags per template?

Yes, it's 10

The description is a text field. I think it should be a text area or markdown editor. Let's start with a text area for this MVP.

Max description length is 1000 characters and it should be informative only, so agree with text area.

The description is required. What about making it optional?

It was mandatory in issue, but I am fine with making it optional.

The description is persisted to local storage. Given that this is a flyout and not a page I think we should not persist it. Otherwise, every time I open the flyout the description of the template I created previously will appear.

Hmm.. yes, this will need some modification in the existing description component. That's why I thought of doing it in next PR, but it makes sense to do it here to test the create template feature properly.

Fixed in a468d94

kibanamachine · 2024-05-31T10:09:20Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6176

[❌] x-pack/test/functional_with_es_ssl/apps/cases/group2/config.ts: 0/25 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/security/config.ts: 0/25 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/observability/config.ts: 0/25 tests passed.

see run history

…, make description optional, show template tags options

kibanamachine · 2024-05-31T17:21:31Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6182

[❌] x-pack/test/functional_with_es_ssl/apps/cases/group2/config.ts: 0/25 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/security/config.ts: 0/25 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/observability/config.ts: 0/25 tests passed.

see run history

doakalexi

I tested locally and worked as expected, LGTM! I was able to create templates with custom fields and a connector. This is really small, but now that the description is optional it'd be good to add the OptionalFieldLabel to match the other optional fields.

…description

js-jankisalvi · 2024-06-03T13:46:15Z

@elasticmachine merge upstream

kibanamachine · 2024-06-03T13:48:49Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6190

[❌] x-pack/test/functional_with_es_ssl/apps/cases/group2/config.ts: 0/25 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/security/config.ts: 0/25 tests passed.
[❌] x-pack/test_serverless/functional/test_suites/observability/config.ts: 0/25 tests passed.

see run history

kibanamachine · 2024-06-04T15:56:48Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6213

[✅] x-pack/test/functional_with_es_ssl/apps/cases/group2/config.ts: 30/30 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/observability/config.ts: 30/30 tests passed.
[✅] x-pack/test_serverless/functional/test_suites/security/config.ts: 30/30 tests passed.

see run history

…lyout

…kibana into case-templates-ui

cnasikas

Great work and great test coverage 🚀 ! I left a couple of comments.

x-pack/plugins/cases/public/components/case_form_fields/index.tsx

x-pack/plugins/cases/public/components/case_form_fields/index.test.tsx

x-pack/plugins/cases/public/components/configure_cases/flyout.test.tsx

x-pack/plugins/cases/public/components/configure_cases/flyout.tsx

x-pack/plugins/cases/public/components/templates/form.test.tsx

x-pack/plugins/cases/public/components/templates/form_fields.tsx

x-pack/plugins/cases/public/components/templates/index.tsx

cnasikas · 2024-06-05T13:18:18Z

x-pack/plugins/cases/public/components/templates/schema.tsx

+
+const { emptyField, maxLengthField } = fieldValidators;
+
+export const schema: FormSchema<TemplateFormProps> = {


A portion of this schema seems identical with the schema defined here x-pack/plugins/cases/public/components/create/schema.tsx. Wdyt about having one base schema common to both? Then, in this file, we can iterate the common schema and add the optional label to the fields we want.

Created schema for case_form_fields and used it in template schema to append optional label. here
We can use the same in create case form as well.

cnasikas

Code LGMT! I tested and everything is working as expected. Thank you for your patience with the review.

x-pack/plugins/cases/public/components/case_form_fields/custom_fields.test.tsx

x-pack/plugins/cases/public/components/configure_cases/index.tsx

kibana-ci · 2024-06-07T17:20:41Z

💔 Build Failed

Failed CI Steps

Post-Build

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [5986cc9]

History

💔 Build #214684 failed e4aa6ad
💔 Build #214487 failed 8379679
💔 Build #214093 failed a28298a
💔 Build #213579 failed a833425
💔 Build #213566 failed 9c29363
💔 Build #213534 failed d298b5a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @js-jankisalvi

js-jankisalvi added 9 commits May 14, 2024 18:10

initial commit

37ac85f

add connector field

9be6c68

map connector fields

edfc999

syncAlerts added

6641ec8

Merge remote-tracking branch 'upstream/feat/case_templates' into case…

e1b6d3a

…-templates-ui

Merge remote-tracking branch 'upstream/feat/case_templates' into case…

6860034

…-templates-ui

add custom fields component

41c025d

Merge remote-tracking branch 'upstream/feat/case_templates' into case…

21436db

…-templates-ui

add tags field, update default value of connector

5de5bd2

js-jankisalvi added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature labels May 23, 2024

js-jankisalvi self-assigned this May 23, 2024

js-jankisalvi added 9 commits May 23, 2024 14:07

add unit tests

027ad22

Remove custom field flyout, add tests

e64508c

add template section description

2024212

remove path from case fields

81f3d0b

add max length validations, tests

95d3c2f

add utils, flyout and configure case tests

03d8f07

add e2e test for templates

448ea94

Merge remote-tracking branch 'upstream/feat/case_templates' into case…

c2d1a35

…-templates-ui

Clean up

db4b1a5

js-jankisalvi added the v8.15.0 label May 30, 2024

set autoFocus

83f3a6d

js-jankisalvi added the release_note:skip Skip the PR/issue when compiling release notes label May 30, 2024

remove caseFields path

1999ca0

js-jankisalvi marked this pull request as ready for review May 30, 2024 17:02

js-jankisalvi requested a review from a team as a code owner May 30, 2024 17:02

cnasikas self-requested a review May 31, 2024 07:45

js-jankisalvi added 2 commits May 31, 2024 09:17

add e2e tests to serverless

49220d9

fix type error

75f24e2

cnasikas reviewed May 31, 2024

View reviewed changes

lint fix title

82cd6af

use description text area, remove session storage key for description…

a468d94

…, make description optional, show template tags options

doakalexi approved these changes May 31, 2024

View reviewed changes

js-jankisalvi added 3 commits June 3, 2024 09:23

fix flaky functional test

ef4dc10

add retry to wait for templates-list to exist, add optional label to …

d298b5a

…description

fix function name

9c29363

Merge branch 'feat/case_templates' into case-templates-ui

a833425

js-jankisalvi added 2 commits June 5, 2024 11:19

add custom_fields tests, remove unnecessary args from renderBody of f…

4f3f91f

…lyout

Merge branch 'case-templates-ui' of https://github.com/js-jankisalvi/…

a28298a

…kibana into case-templates-ui

cnasikas reviewed Jun 5, 2024

View reviewed changes

js-jankisalvi requested review from JiaweiWu and removed request for JiaweiWu June 5, 2024 15:29

js-jankisalvi added 2 commits June 6, 2024 16:06

PR feedback 1

8379679

PR feedback 2

e4aa6ad

cnasikas approved these changes Jun 7, 2024

View reviewed changes

x-pack/plugins/cases/public/components/case_form_fields/custom_fields.test.tsx Outdated Show resolved Hide resolved

x-pack/plugins/cases/public/components/configure_cases/index.tsx Outdated Show resolved Hide resolved

js-jankisalvi added 3 commits June 7, 2024 16:00

typo fixed

95a77b4

test update

dc64cc8

Merge branch 'feat/case_templates' into case-templates-ui

d5b7f24

js-jankisalvi merged commit c511009 into elastic:feat/case_templates Jun 7, 2024
23 of 24 checks passed

js-jankisalvi deleted the case-templates-ui branch June 7, 2024 17:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ResponseOps][Cases] Allow users to create templates #184104

[ResponseOps][Cases] Allow users to create templates #184104

js-jankisalvi commented May 23, 2024 •

edited

Loading

elasticmachine commented May 30, 2024

elasticmachine commented May 30, 2024

cnasikas left a comment •

edited

Loading

js-jankisalvi commented May 31, 2024 •

edited

Loading

kibanamachine commented May 31, 2024

kibanamachine commented May 31, 2024

doakalexi left a comment •

edited

Loading

js-jankisalvi commented Jun 3, 2024

kibanamachine commented Jun 3, 2024

kibanamachine commented Jun 4, 2024

cnasikas left a comment

cnasikas Jun 5, 2024

js-jankisalvi Jun 7, 2024 •

edited

Loading

cnasikas left a comment

kibana-ci commented Jun 7, 2024


		const { emptyField, maxLengthField } = fieldValidators;

		export const schema: FormSchema<TemplateFormProps> = {

[ResponseOps][Cases] Allow users to create templates #184104

[ResponseOps][Cases] Allow users to create templates #184104

Conversation

js-jankisalvi commented May 23, 2024 • edited Loading

Summary

Checklist

elasticmachine commented May 30, 2024

elasticmachine commented May 30, 2024

cnasikas left a comment • edited Loading

Choose a reason for hiding this comment

js-jankisalvi commented May 31, 2024 • edited Loading

kibanamachine commented May 31, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6176

kibanamachine commented May 31, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6182

doakalexi left a comment • edited Loading

Choose a reason for hiding this comment

js-jankisalvi commented Jun 3, 2024

kibanamachine commented Jun 3, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6190

kibanamachine commented Jun 4, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#6213

cnasikas left a comment

Choose a reason for hiding this comment

cnasikas Jun 5, 2024

Choose a reason for hiding this comment

js-jankisalvi Jun 7, 2024 • edited Loading

Choose a reason for hiding this comment

cnasikas left a comment

Choose a reason for hiding this comment

kibana-ci commented Jun 7, 2024

💔 Build Failed

Failed CI Steps

Metrics [docs]

History

js-jankisalvi commented May 23, 2024 •

edited

Loading

cnasikas left a comment •

edited

Loading

js-jankisalvi commented May 31, 2024 •

edited

Loading

doakalexi left a comment •

edited

Loading

js-jankisalvi Jun 7, 2024 •

edited

Loading