Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] [Grouping] Re-add support to custom Group By title in the useGetGroupSelector hook #184165

Merged
merged 4 commits into from
May 29, 2024
Merged

[Security Solution] [Grouping] Re-add support to custom Group By title in the useGetGroupSelector hook #184165

merged 4 commits into from
May 29, 2024

Conversation

opauloh
Copy link
Contributor

@opauloh opauloh commented May 23, 2024

Summary

This PR fixes a regression from PR #180016 where the support to the custom title on the useGetGroupSelector hook was dropped and the Findings DataTables was displaying "Group alerts by" instead of "Group findings by". Unit tests were added to prevent further regressions.

Screenshots

image

image

image

@opauloh opauloh added Team:Threat Hunting Security Solution Threat Hunting Team Team:Cloud Security Cloud Security team related labels May 23, 2024
@opauloh opauloh requested a review from a team as a code owner May 23, 2024 18:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@opauloh opauloh added the release_note:skip Skip the PR/issue when compiling release notes label May 23, 2024
kqualters-elastic
kqualters-elastic approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@kqualters-elastic kqualters-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 sorry about that, that branch really was long lived, bad merge by me

kapral18
kapral18 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@kapral18 kapral18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opauloh opauloh requested a review from a team as a code owner May 28, 2024 18:11
@opauloh opauloh requested a review from umbopepato May 28, 2024 18:14
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 447.7KB 447.7KB +10.0B
securitySolution 15.2MB 15.2MB +20.0B
total +30.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

umbopepato
umbopepato approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@umbopepato umbopepato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@opauloh opauloh merged commit 12f35c9 into elastic:main May 29, 2024
17 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label May 29, 2024
rshen91 pushed a commit to rshen91/kibana that referenced this pull request May 30, 2024
@opauloh @rshen91
[Security Solution] [Grouping] Re-add support to custom Group By titl…
8734eb2 
…e in the useGetGroupSelector hook (elastic#184165)

## Summary

This PR fixes a regression from PR elastic#180016 where the support to the
custom title on the `useGetGroupSelector` hook was dropped and the
Findings DataTables was displaying "Group alerts by" instead of "Group
findings by". Unit tests were added to prevent further regressions.


## Screenshots


![image](https://github.com/elastic/kibana/assets/19270322/97ac29f7-d314-4df9-a4d8-9a11b198f021)


![image](https://github.com/elastic/kibana/assets/19270322/6e6a3eef-fd4e-4619-a460-a3b0fb46ec37)


![image](https://github.com/elastic/kibana/assets/19270322/e6bcd40c-45e6-4444-8905-7c7c2c900926)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapral18 kapral18 kapral18 approved these changes

@umbopepato umbopepato umbopepato approved these changes

@kqualters-elastic kqualters-elastic kqualters-elastic approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related Team:Threat Hunting Security Solution Threat Hunting Team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@opauloh @elasticmachine @kibana-ci @kapral18 @umbopepato @kqualters-elastic @kibanamachine