Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Improve user messagging #184233

Merged
merged 13 commits into from
Jun 5, 2024

Conversation

markov00
Copy link
Member

@markov00 markov00 commented May 24, 2024

Summary

This PR cleaned up a bit our user messages. In particular:

Subsequent possible steps, outside this PR:

@markov00 markov00 marked this pull request as ready for review May 28, 2024 15:49
@markov00 markov00 requested a review from a team as a code owner May 28, 2024 15:49
@markov00 markov00 added technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes labels May 28, 2024
@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #7 / useGetEndpointActionList hook should call the proper API

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lens 1475 1476 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +4.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@markov00 markov00 merged commit e12c7e3 into elastic:main Jun 5, 2024
19 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 5, 2024
@markov00 markov00 deleted the 2024_05_21-improve_user_messagging branch June 5, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants