[ML] AIOps Log Rate Analysis: adds controls for controlling which columns will be visible #184262

alvarezmelissa87 · 2024-05-24T20:10:33Z

Summary

Related meta issue: #182714

This PR adds controls to the AIOps results table to show/hide columns.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

…lumns to hook.

alvarezmelissa87 · 2024-05-31T14:42:43Z

@elasticmachine merge upstream

x-pack/plugins/aiops/public/components/log_rate_analysis/item_filter_popover.tsx

x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/use_columns.tsx

x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_results.tsx

x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/use_columns.tsx

x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_results.tsx

peteharverson · 2024-06-05T13:26:05Z

x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_results.tsx

+const disabledColumnFilterApplyButtonTooltipContent = i18n.translate(
+  'xpack.aiops.analysis.columnSelectorNotEnoughColumnsSelected',
+  {
+    defaultMessage: 'At least one column must be selected.',


Is the 'at least one' correct? It seems to require at least two columns.

Good catch - fixed in 72f120e

x-pack/plugins/aiops/public/components/log_rate_analysis/item_filter_popover.tsx

elasticmachine · 2024-06-05T22:12:35Z

Pinging @elastic/ml-ui (:ml)

alvarezmelissa87 · 2024-06-05T22:12:47Z

@elasticmachine merge upstream

x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_results.tsx

peteharverson · 2024-06-06T09:42:14Z

x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_results.tsx

+            itemSearchAriaLabel={columnSearchAriaLabel}
+            initialSkippedItems={skippedColumns}
+            popoverButtonTitle={columnsButton}
+            selectedItemLimit={1}


I'm seeing a weird issue where if I open the popover, hit 'Deselect all', I then have to select 2 items (or sometimes more) to get the Apply button enabled:

Good catch! Fixed this issue in 7f58298
It now takes into account the incoming skipped items 👍

alvarezmelissa87 · 2024-06-06T18:12:40Z

This is ready for a final look when you get a chance 🙏 cc @peteharverson, @qn895

qn895 · 2024-06-06T19:15:08Z

x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/use_columns.tsx

+  'xpack.aiops.logRateAnalysis.resultsTable.logRateColumnTooltip',
+  {
+    defaultMessage:
+      'A visual representation of the impact of the field on the message rate difference',


nit: Does this message need to end with a period?

qn895 · 2024-06-06T19:15:22Z

x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/use_columns.tsx

+const groupImpactMessage = i18n.translate(
+  'xpack.aiops.logRateAnalysis.resultsTableGroups.impactLabelColumnTooltip',
+  {
+    defaultMessage: 'The level of impact of the group on the message rate difference',


nit: Does this message need to end with a period?

qn895

Latest changes LGTM

peteharverson

Tested latest changes and LGTM

jgowdyelastic · 2024-06-07T14:51:43Z

x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_results.tsx

@@ -157,6 +193,7 @@ export const LogRateAnalysisResults: FC<LogRateAnalysisResultsProps> = ({
  );
  const [shouldStart, setShouldStart] = useState(false);
  const [toggleIdSelected, setToggleIdSelected] = useState(resultsGroupedOffId);
+  const [skippedColumns, setSkippedColumns] = useState<string[]>(['p-value']);


It would be nice if this could be ColumnNames[] rather than string. It'll probably mean changing all places where they are stored as a string array, but it'd be useful to use the types to enforce that only the correct values are used.

Updated in c1876b9

alvarezmelissa87 · 2024-06-07T23:21:56Z

@elasticmachine merge upstream

alvarezmelissa87 · 2024-06-10T15:37:51Z

@elasticmachine merge upstream

kibana-ci · 2024-06-10T17:12:43Z

💚 Build Succeeded

Buildkite Build
Commit: 79ddbf4

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`aiops`	620	622	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiops`	549.3KB	549.9KB	+589.0B

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`aiops`	29	31	+2

Total ESLint disabled count

id	before	after	diff
`aiops`	29	31	+2

History

💛 Build #214810 was flaky 9fdefb7
💔 Build #214794 failed ec52573
💔 Build #214775 failed c1876b9
💔 Build #214601 failed 2c85b9c
💔 Build #214546 failed 7f58298
💔 Build #214317 failed e782ed5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

convert FieldFilterPopover to generic ItemFieldFilterPopover. Move co…

837278c

…lumns to hook.

alvarezmelissa87 added release_note:enhancement :ml Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.15.0 labels May 24, 2024

alvarezmelissa87 self-assigned this May 24, 2024

ensure row stays expanded

fb4ce79

alvarezmelissa87 mentioned this pull request May 24, 2024

[ML] AIOps Log Rate Analysis: improve explanation of log rate spike/dip #182714

Closed

2 tasks

alvarezmelissa87 requested review from qn895, jgowdyelastic and darnautov May 24, 2024 23:31

Merge branch 'main' into ml-aiops-results-add-column-control

eab8703

qn895 reviewed May 31, 2024

View reviewed changes

x-pack/plugins/aiops/public/components/log_rate_analysis/item_filter_popover.tsx Outdated Show resolved Hide resolved

qn895 reviewed May 31, 2024

View reviewed changes

x-pack/plugins/aiops/public/components/log_rate_analysis/item_filter_popover.tsx Outdated Show resolved Hide resolved

qn895 reviewed May 31, 2024

View reviewed changes

x-pack/plugins/aiops/public/components/log_rate_analysis/item_filter_popover.tsx Outdated Show resolved Hide resolved

qn895 reviewed May 31, 2024

View reviewed changes

x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/use_columns.tsx Show resolved Hide resolved

qn895 reviewed May 31, 2024

View reviewed changes

x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_results.tsx Outdated Show resolved Hide resolved

peteharverson reviewed Jun 5, 2024

View reviewed changes

ensure columns are internationalized

72f120e

alvarezmelissa87 marked this pull request as ready for review June 5, 2024 22:12

alvarezmelissa87 requested a review from a team as a code owner June 5, 2024 22:12

Merge branch 'main' into ml-aiops-results-add-column-control

e782ed5

qn895 reviewed Jun 5, 2024

View reviewed changes

x-pack/plugins/aiops/public/components/log_rate_analysis/log_rate_analysis_results.tsx Show resolved Hide resolved

peteharverson reviewed Jun 6, 2024

View reviewed changes

fix select/deselect all functionality

7f58298

qn895 reviewed Jun 6, 2024

View reviewed changes

qn895 approved these changes Jun 6, 2024

View reviewed changes

ensure correct docCount field is shown

2c85b9c

peteharverson approved these changes Jun 7, 2024

View reviewed changes

jgowdyelastic reviewed Jun 7, 2024

View reviewed changes

alvarezmelissa87 added 4 commits June 7, 2024 12:34

update functional tests

c2afed2

update type for skipped columns state

c1876b9

make prettier happy

ec52573

update log rate table test

9762710

Merge branch 'main' into ml-aiops-results-add-column-control

9fdefb7

Merge branch 'main' into ml-aiops-results-add-column-control

79ddbf4

alvarezmelissa87 merged commit 2c76ad0 into elastic:main Jun 10, 2024
17 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Jun 10, 2024

alvarezmelissa87 deleted the ml-aiops-results-add-column-control branch June 10, 2024 17:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] AIOps Log Rate Analysis: adds controls for controlling which columns will be visible #184262

[ML] AIOps Log Rate Analysis: adds controls for controlling which columns will be visible #184262

alvarezmelissa87 commented May 24, 2024 •

edited

Loading

alvarezmelissa87 commented May 31, 2024

peteharverson Jun 5, 2024

alvarezmelissa87 Jun 5, 2024

elasticmachine commented Jun 5, 2024

alvarezmelissa87 commented Jun 5, 2024

peteharverson Jun 6, 2024

alvarezmelissa87 Jun 6, 2024

alvarezmelissa87 commented Jun 6, 2024

qn895 Jun 6, 2024

qn895 Jun 6, 2024

qn895 left a comment

peteharverson left a comment

jgowdyelastic Jun 7, 2024 •

edited

Loading

alvarezmelissa87 Jun 7, 2024

alvarezmelissa87 commented Jun 7, 2024

alvarezmelissa87 commented Jun 10, 2024

kibana-ci commented Jun 10, 2024

ESLint disabled line counts

Total ESLint disabled count

[ML] AIOps Log Rate Analysis: adds controls for controlling which columns will be visible #184262

[ML] AIOps Log Rate Analysis: adds controls for controlling which columns will be visible #184262

Conversation

alvarezmelissa87 commented May 24, 2024 • edited Loading

Summary

Checklist

alvarezmelissa87 commented May 31, 2024

peteharverson Jun 5, 2024

Choose a reason for hiding this comment

alvarezmelissa87 Jun 5, 2024

Choose a reason for hiding this comment

elasticmachine commented Jun 5, 2024

alvarezmelissa87 commented Jun 5, 2024

peteharverson Jun 6, 2024

Choose a reason for hiding this comment

alvarezmelissa87 Jun 6, 2024

Choose a reason for hiding this comment

alvarezmelissa87 commented Jun 6, 2024

qn895 Jun 6, 2024

Choose a reason for hiding this comment

qn895 Jun 6, 2024

Choose a reason for hiding this comment

qn895 left a comment

Choose a reason for hiding this comment

peteharverson left a comment

Choose a reason for hiding this comment

jgowdyelastic Jun 7, 2024 • edited Loading

Choose a reason for hiding this comment

alvarezmelissa87 Jun 7, 2024

Choose a reason for hiding this comment

alvarezmelissa87 commented Jun 7, 2024

alvarezmelissa87 commented Jun 10, 2024

kibana-ci commented Jun 10, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

ESLint disabled line counts

Total ESLint disabled count

History

alvarezmelissa87 commented May 24, 2024 •

edited

Loading

jgowdyelastic Jun 7, 2024 •

edited

Loading