Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] accept negated index patterns #184528

Merged
merged 2 commits into from
May 31, 2024
Merged

[ES|QL] accept negated index patterns #184528

merged 2 commits into from
May 31, 2024

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented May 30, 2024 •
edited
Loading

Summary

*, -.* is now acceptable.

Checklist

@drewdaemon drewdaemon added Feature:ES|QL Team:ESQL ES|QL related features in Kibana labels May 30, 2024
@drewdaemon
Copy link
Contributor Author

/ci

@drewdaemon drewdaemon mentioned this pull request May 30, 2024
Open
27 tasks
@drewdaemon drewdaemon marked this pull request as ready for review May 30, 2024 17:25
@drewdaemon drewdaemon requested a review from a team as a code owner May 30, 2024 17:25
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@drewdaemon drewdaemon requested a review from sphilipse May 30, 2024 17:26
stratoula
stratoula approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, grazie!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.2MB 3.2MB +22.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit 4e8876d into elastic:main May 31, 2024
21 checks passed
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stratoula stratoula stratoula approved these changes

@sphilipse sphilipse Awaiting requested review from sphilipse

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:ES|QL release_note:fix Team:ESQL ES|QL related features in Kibana v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@drewdaemon @elasticmachine @kibana-ci @stratoula @kibanamachine