Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Observability Onboarding] Update question contents to match new designs #184866

Conversation

justinkambic
Copy link
Contributor

@justinkambic justinkambic commented Jun 5, 2024

Summary

Resolves #184108.

Resolves #181855.

Updates the o11y onboarding flow's first question to match our latest designs. This includes changing the avatar icon at the beginning of the flow, updating the copy for the first question, adding a list of integration icons that pertain to each question, and including a badge to indicate that the user can add additional integrations for each option.

From a technical perspective, I have added a type to indicate the supported icon values. Many of these logos are natively supported by EUI, but I did introduce three new SVG to the plugin's assets folder.

Before

image

After

image

@justinkambic justinkambic added release_note:enhancement Team:obs-ux-logs Observability Logs User Experience Team v8.15.0 labels Jun 5, 2024
@justinkambic justinkambic self-assigned this Jun 5, 2024
@justinkambic justinkambic requested review from a team as code owners June 5, 2024 18:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Jun 5, 2024
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, but the icons shouldn't switch to individual rows on narrow screens:

Screenshot 2024-06-06 at 10 05 33

<FormattedMessage
defaultMessage="+ Integrations"
id="xpack.observability_onboarding.experimentalOnboardingFlow.form.addIntegrations"
description={
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this description!

@justinkambic
Copy link
Contributor Author

the icons shouldn't switch to individual rows on narrow screens

Couldn't agree more, thanks for finding this.

@justinkambic justinkambic force-pushed the 184108/add-use-case-logos-and-update-copy branch from 82152dc to d804b37 Compare June 6, 2024 14:34
@justinkambic justinkambic force-pushed the 184108/add-use-case-logos-and-update-copy branch from d804b37 to 121dcf6 Compare June 6, 2024 18:45
@kibana-ci
Copy link
Collaborator

kibana-ci commented Jun 10, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityOnboarding 198.7KB 199.8KB +1.2KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @justinkambic

@justinkambic justinkambic merged commit ac6a8a2 into elastic:main Jun 11, 2024
20 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jun 11, 2024
@justinkambic justinkambic deleted the 184108/add-use-case-logos-and-update-copy branch June 11, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting ci:project-deploy-observability Create an Observability project release_note:enhancement Team:obs-ux-logs Observability Logs User Experience Team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logos on use cases & change icon + copy on first question Fix alignment of second question icon
6 participants