[Embeddables Rebuild] Fix unsaved changes on new dashboards bug #184955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heenawter
added
release_note:fix
Team:Presentation
|
/ci |
Heenawter
commented
Jun 6, 2024
Comment on lines
+121
to
+131
| return (async () => { | ||
| const { | ||
| explicitInput: currentInput, | ||
| componentState: { lastSavedInput }, | ||
| } = this.getState(); | ||
| getDashboardUnsavedChanges | ||
| .bind(this)(lastSavedInput, currentInput) | ||
| .then((unsavedChanges) => { | ||
| if (observer.closed) return; | ||
| observer.next(unsavedChanges); | ||
| }); | ||
| }); | ||
| const unsavedChanges = await getDashboardUnsavedChanges.bind(this)( | ||
| lastSavedInput, | ||
| currentInput | ||
| ); | ||
| return unsavedChanges; | ||
| })(); |
There was a problem hiding this comment.
Switched to return a promise rather than an observable - this is a stylistic change and has nothing to do with the actual bug.
There was a problem hiding this comment.
Thanks for making this change. IMO it's much more obvious what's actually happening here when we use a promise
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
ThomThomson
approved these changes
Jun 6, 2024
kibanamachine
added
v8.15.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #184174
Summary
This PR fixes the bug where, on a new and unsaved dashboard, adding both a legacy embeddable and an image embeddable would result in a dashboard getting stuck with unsaved changes on the first save. This was caused by a race condition - since the
debounceon the React embeddable unsaved changes observable was before theswitchMap, the React embeddable observable fired immediately on save which then triggered thediffingSubscriptionto fire too early.Before:
Screen.Recording.2024-06-06.at.11.04.04.AM.mov
After:
Screen.Recording.2024-06-06.at.10.59.05.AM.mov