[Synthetucs] Added perf metrics for es queries #186313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
shahzad31
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
botelastic
bot
added
ci:project-deploy-observability
kpatticha
reviewed
Jun 20, 2024
| @@ -138,7 +143,10 @@ export class Plugin | |||
| return { | |||
| createExploratoryViewUrl, | |||
| getAppDataView: getAppDataView(pluginsStart.dataViews), | |||
| ExploratoryViewEmbeddable: getExploratoryViewEmbeddable({ ...coreStart, ...pluginsStart }), | |||
| ExploratoryViewEmbeddable: getExploratoryViewEmbeddable( | |||
| { ...coreStart, ...pluginsStart }, | |||
There was a problem hiding this comment.
The this.analyticsService should be part of coreStart?
There was a problem hiding this comment.
well it's coming from coreSetup, not coreStart.
kpatticha
reviewed
Jun 20, 2024
| if (requests && analytics) { | ||
| const listReq = requests.getRequests(); | ||
| if (listReq.length > 0) { | ||
| // find the highest query time |
There was a problem hiding this comment.
Can you please elaborate why you need to find the highest query time?
There was a problem hiding this comment.
it's because a chart may have many other queries , so we only care about slowest query.
shahzad31
commented
Jun 20, 2024
...lution/exploratory_view/public/components/shared/exploratory_view/hooks/use_ebt_telemetry.ts
Outdated
Show resolved
Hide resolved
…components/shared/exploratory_view/hooks/use_ebt_telemetry.ts
kpatticha
approved these changes
Jun 20, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.15.0
backport:skip
bhapas
pushed a commit
to bhapas/kibana
that referenced
this pull request
Jun 24, 2024
## Summary Added perf metrics for es queries !! Fixes elastic/synthetics-dev#351 Started reporting query time for exploratory based visualizations used in Synthetics Test data can be seen on staging telemetry cluster !! <img width="1698" alt="image" src="https://github.com/elastic/kibana/assets/3505601/120d9ea6-0162-4f56-8168-001b749d31e8"> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added perf metrics for es queries !!
Fixes https://github.com/elastic/synthetics-dev/issues/351
Started reporting query time for exploratory based visualizations used in Synthetics
Test data can be seen on staging telemetry cluster !!