Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Onboarding] k8s quickstart flow #186380
[Onboarding] k8s quickstart flow #186380
Changes from all commits
dbe4503
4025406
226ec13
03e7350
bd2e6a2
88030c9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be hard coded or could the ID change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first I implemented a logic to search for dashboard ID by it's title as there seemed to be no other way to reliably reference it, but then I saw that dashboard IDs are hardcoded in a few places in Fleet plugin. Those ID seem to be pard of the dashboard definition and don't change, in the integration code there are multiple iterations on a single dashboard without the ID being changed, so I assume it's save to use it on or side as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's interesting, I assumed these need to be loaded in dynamically.
@kpollich Are the installed dashboard IDs returned by Fleet packages static? We need a way of determining which dashboard should be the main one we direct users to, after log data has been successfully ingested, so hard coding an ID for each integration would make that easy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are defined via the integration package, so theoretically they could change on package update. Changing this ID would also affect bookmarks etc., so they should normally stay stable.
It feels OK to rely on this, especially if we already do it in other places - if it breaks, we could consider it a bug in the integration. But also interested in @kpollich s opinion here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there might be a case where the id is different when multiple spaces are involved - not sure how this case is normally handled...