-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] AIOps: Adds AI Assistant contextual insight to Log Rate Analysis page in ML plugin in Observability serverless. #186509
Conversation
Pinging @elastic/ml-ui (:ml) |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @walterra |
onWindowParametersChange={onWindowParametersHandler} | ||
/> | ||
<EuiFlexItem> | ||
<LogRateAnalysisContent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we clear this info if the brushes are reset or when a new analysis is run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this to #181111. I think it makes sense to clear the reset AI assistant section when Reset is pressed or when a new analysis is run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally against a range of logs, and overall looks a great addition.
Couple of questions:
- Guessing this is the default behavior of the AI assistant, but is there a way to prevent this toast from appearing if a user decides to click the 'Stop generating' button:
![Screenshot 2024-06-20 at 17 21 34](https://private-user-images.githubusercontent.com/7405507/341490505-89a28471-0fd0-415a-9205-7bf92a2bbb5c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA4NDk2MTEsIm5iZiI6MTcyMDg0OTMxMSwicGF0aCI6Ii83NDA1NTA3LzM0MTQ5MDUwNS04OWEyODQ3MS0wZmQwLTQxNWEtOTIwNS03YmY5MmEyYmJiNWMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTNUMDU0MTUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTMyYjBkYWRlYmY0ZWZhMjIwMWIxYjg2Yjk1ZGQyOWZiZmE1ZmJkYTZhNDRjODdkODVmNWI0NjIwOGIyNGNiMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.ZKregUv52NBBBGCw5comgW3pk_EGRtl8AL5VIoZ-rJw)
- Have you confirmed that behavior is ok with Security and Search serverless projects (assume the assistant is just silently hidden)?
@peteharverson regarding your questions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@alvarezmelissa87 I investigated the non-working "Start chat" button. The problem is: This button will trigger the AI Assistant flyout to start a chat with the assistant, but it is not available outside the o11y UI on stateful. The contextual insight on the other hand doesn't expose options to hide that button in this case. Since the AI assistant chat is only available all the time in the o11y project type for serverless, for now I had to add a flag that will show the contextual insights on the log rate analysis page on serverless too (see d7aa6f4). |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
cc @walterra |
Summary
Part of #181111.
This adds O11y AI Assistant's contextual insight to the Log Rate Analysis page in the ML plugin for O11y serverless projects..
Note the code is almost an exact copy of what's currently used in the O11y UI itself to render the contextual insight when log rate analysis gets embedded on alert details pages. As a follow up we will be able to consolidate some code.
aiops-ai-assistant-contextual-insight-0001.webm
To test this you need to set up AI Assistant in your
kibana.dev.yml
:Checklist