[ML] AIOps: Fix the text field icon margins in the log rate analysis results table. #186520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
:ml
release_note:skip
|
Pinging @elastic/ml-ui (:ml) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @walterra |
bhapas
pushed a commit
to bhapas/kibana
that referenced
this pull request
Jun 24, 2024
…results table. (elastic#186520) ## Summary Part of elastic#181111. Fixes the regression where the text field icon margins in the log rate analysis results table were not rendered. It turned out the css applied to `EuiIconTip` was not picked up correctly. Wrapping it in a `span` applies it correctly. Before: <img width="1094" alt="image" src="https://github.com/elastic/kibana/assets/230104/fd1a3e09-1815-490c-9c6a-ded3af71cf15"> After: <img width="1098" alt="image" src="https://github.com/elastic/kibana/assets/230104/4522f85a-82b5-4009-9ac5-ad207ac7b3e3"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #181111.
Fixes the regression where the text field icon margins in the log rate analysis results table were not rendered. It turned out the css applied to
EuiIconTipwas not picked up correctly. Wrapping it in aspanapplies it correctly.Before:
After:
Checklist