Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rollups] Add attributes for tracking doc links clicks #186612

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

ElenaStoeva
Copy link
Contributor

@ElenaStoeva ElenaStoeva commented Jun 21, 2024

Closes #186610

Summary

This PR adds data-test-subj attributes to the doc links in the Rollup deprecation warning callout and the deprecation empty callout so that clicks on these links can be tracked on Fullstory. The links on the deprecation callout have test subjects with a prefix depending on whether they are on the list view page or the create form page so that we can differentiate the clicks from the different pages.

@ElenaStoeva ElenaStoeva added release_note:skip Skip the PR/issue when compiling release notes Feature:Rollups labels Jun 21, 2024
@ElenaStoeva ElenaStoeva self-assigned this Jun 21, 2024
@ElenaStoeva
Copy link
Contributor Author

/ci

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
rollup 115.2KB 115.5KB +266.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ElenaStoeva

@ElenaStoeva ElenaStoeva added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Jun 21, 2024
@ElenaStoeva ElenaStoeva marked this pull request as ready for review June 21, 2024 13:28
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner June 21, 2024 13:28
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@ElenaStoeva ElenaStoeva merged commit d16d402 into elastic:main Jun 21, 2024
26 checks passed
@ElenaStoeva ElenaStoeva deleted the rollups/link-clicks-tracking branch June 21, 2024 15:05
@kibanamachine kibanamachine added v8.15.0 backport:skip This commit does not require backporting labels Jun 21, 2024
bhapas pushed a commit to bhapas/kibana that referenced this pull request Jun 24, 2024
Closes elastic#186610

## Summary

This PR adds `data-test-subj` attributes to the doc links in the Rollup
deprecation warning callout and the deprecation empty callout so that
clicks on these links can be tracked on Fullstory. The links on the
deprecation callout have test subjects with a prefix depending on
whether they are on the list view page or the create form page so that
we can differentiate the clicks from the different pages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Rollups release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Rollups] Add tracking of link clicks on the deprecation warning callout and empty prompt
5 participants