[Obs AI Assistant] Handle Axios errors correctly #186790
Merged
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgieselaar
added
bug
botelastic
bot
added
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
dgieselaar
added
the
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
HistoryTo update your PR or re-run it, just comment with: cc @dgieselaar |
sorenlouv
approved these changes
Jun 24, 2024
sorenlouv
reviewed
Jun 24, 2024
| } | ||
|
|
||
| delete sanitizedError.stack; |
There was a problem hiding this comment.
nit: I have an aversion against delete and prefer explicitly picking the properties we expect
There was a problem hiding this comment.
it would be omit in that case (no way for us to account for all the possible properties of this object). In this case I prefer deleteing properties of an object that is created a few lines up over having to re-assign stuff because of omit/pick.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 25, 2024
the `kibana` function throws an axios error, and it resulted in an error because `toJSON()` doesn't actually return a string like I expected it to, it returns a structured object that can be converted into a string by calling JSON.stringify(). (cherry picked from commit ca41e66)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 25, 2024
…86865) # Backport This will backport the following commits from `main` to `8.14`: - [[Obs AI Assistant] Handle Axios errors correctly (#186790)](#186790) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dario Gieselaar","email":"dario.gieselaar@elastic.co"},"sourceCommit":{"committedDate":"2024-06-25T06:38:22Z","message":"[Obs AI Assistant] Handle Axios errors correctly (#186790)\n\nthe `kibana` function throws an axios error, and it resulted in an error\r\nbecause `toJSON()` doesn't actually return a string like I expected it\r\nto, it returns a structured object that can be converted into a string\r\nby calling JSON.stringify().","sha":"ca41e6685ea245ea8d7fb3f39b31fa18f5134821","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Obs AI Assistant","ci:project-deploy-observability","v8.15.0","v8.14.2"],"title":"[Obs AI Assistant] Handle Axios errors correctly","number":186790,"url":"#186790 AI Assistant] Handle Axios errors correctly (#186790)\n\nthe `kibana` function throws an axios error, and it resulted in an error\r\nbecause `toJSON()` doesn't actually return a string like I expected it\r\nto, it returns a structured object that can be converted into a string\r\nby calling JSON.stringify().","sha":"ca41e6685ea245ea8d7fb3f39b31fa18f5134821"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"#186790 AI Assistant] Handle Axios errors correctly (#186790)\n\nthe `kibana` function throws an axios error, and it resulted in an error\r\nbecause `toJSON()` doesn't actually return a string like I expected it\r\nto, it returns a structured object that can be converted into a string\r\nby calling JSON.stringify().","sha":"ca41e6685ea245ea8d7fb3f39b31fa18f5134821"}},{"branch":"8.14","label":"v8.14.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dario Gieselaar <dario.gieselaar@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
kibanafunction throws an axios error, and it resulted in an error becausetoJSON()doesn't actually return a string like I expected it to, it returns a structured object that can be converted into a string by calling JSON.stringify().