-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Added OAS dev tutorial #187573
Open
jloleysens
wants to merge
5
commits into
elastic:main
Choose a base branch
from
jloleysens:docs/oas-tutorial
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Docs] Added OAS dev tutorial #187573
+188
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-core (Team:Core) |
jloleysens
commented
Jul 4, 2024
Comment on lines
+91
to
+96
{ | ||
collection: 'Elastic Developer Guide', | ||
navs: ['nav-elastic-developer-guide'], | ||
}, | ||
{ collection: 'Kibana Team', navs: ['nav-kibana-team'] }, | ||
{ collection: 'Kibana Developer Guide', navs: ['nav-kibana-dev'] }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason I was getting errors when these where just strings... Not sure whether it was necessarily this but I updated it and it worked so 🤷🏻
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
cc @jloleysens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Feature:OAS
Work or issues related to Core-provided mechanisms for generating OAS
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Screenshot